Date: Fri, 12 Oct 2018 20:41:30 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, portmgr@FreeBSD.org, perl@FreeBSD.org Subject: Re: svn commit: r481365 - in head: archivers/p5-Archive-Any archivers/p5-Archive-Any-Plugin-Rar archivers/p5-Archive-Extract-Libarchive archivers/p5-Archive-Peek archivers/p5-Archive-Rar archivers/p5-A... Message-ID: <20181012174130.GF79805@hades.panopticon> In-Reply-To: <201810061306.w96D6jJe040138@repo.freebsd.org> References: <201810061306.w96D6jJe040138@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dag-Erling Smørgrav (des@FreeBSD.org) wrote: > Author: des > Date: Sat Oct 6 13:06:42 2018 > New Revision: 481365 > URL: https://svnweb.freebsd.org/changeset/ports/481365 > > Log: > Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except > for where it resulted in a change in output from build-depends-list or > run-depends-list. > > Approved by: portmgr (adamw) What exactly is this `fixing'? This is explicitly stated in PHB 5.9.2 as wrong: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#makefile-run_depends > -BUILD_DEPENDS= p5-Object-Tiny>=0:devel/p5-Object-Tiny > -RUN_DEPENDS:= ${BUILD_DEPENDS} > +BUILD_DEPENDS= ${RUN_DEPENDS} > +RUN_DEPENDS= p5-Object-Tiny>=0:devel/p5-Object-Tiny After this change, if something is added to RUN_DEPENDS, it'll end up in BUILD_DEPENDS as well. This already leads to perl being mentioned in BUILD_DEPENDS twice. Here's another example: % grep nmap /usr/ports/net-mgmt/p5-FusionInventory-Agent/Makefile NETDISC_RUN_DEPENDS= nmap:security/nmap \ The intent is clearly for nmap to be added to run depends only. But: % WITH=NETDISC make -C /usr/ports/net-mgmt/p5-FusionInventory-Agent -V RUN_DEPENDS | grep -o ' nmap' nmap % WITH=NETDISC make -C /usr/ports/net-mgmt/p5-FusionInventory-Agent -V BUILD_DEPENDS | grep -o ' nmap' nmap -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: https://github.com/AMDmi3
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181012174130.GF79805>