From owner-svn-src-all@FreeBSD.ORG  Thu Jan 22 23:03:56 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DE4C8F3D;
 Thu, 22 Jan 2015 23:03:56 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 654AE299;
 Thu, 22 Jan 2015 23:03:55 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t0MN3rtx087989
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 23 Jan 2015 02:03:53 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t0MN3r5R087988;
 Fri, 23 Jan 2015 02:03:53 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 23 Jan 2015 02:03:53 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Will Andrews <will@FreeBSD.org>
Subject: Re: svn commit: r277530 - head/sys/netinet
Message-ID: <20150122230353.GQ15484@FreeBSD.org>
References: <201501221709.t0MH9svg093005@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201501221709.t0MH9svg093005@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jan 2015 23:03:57 -0000

On Thu, Jan 22, 2015 at 05:09:54PM +0000, Will Andrews wrote:
W> Author: will
W> Date: Thu Jan 22 17:09:54 2015
W> New Revision: 277530
W> URL: https://svnweb.freebsd.org/changeset/base/277530
W> 
W> Log:
W>   Improve CARP logging so that all state transitions are logged.
W>   
W>   sys/netinet/ip_carp.c:
W>   	Add a "reason" string parameter to carp_set_state() and
W>   	carp_master_down_locked() allowing more specific logging
W>   	information to be passed into these apis.
W>   
W>   	Refactor existing state transition logging into a single
W>   	log call in carp_set_state().
W>   
W>   	Update all calls to carp_set_state() and
W>   	carp_master_down_locked() to pass an appropriate reason
W>   	string.  For state transitions that were previously logged,
W>   	the output should be unchanged.
W>   
W>   Submitted by:	gibbs (original), asomers (updated)
W>   MFC after:	1 week
W>   Sponsored by:	Spectra Logic
W>   MFSpectraBSD:	1039697 on 2014/02/11 (original)
W>   		1049992 on 2014/03/21 (updated)

Very nice, thanks!

The only thing I'd suggest to change is "SIOCSVH". You and me, we understand
this enchantment word, but average user Joe doesn't. :) May be a text like
"user requested" or something else. I don't insist on anything, as I am not
native speaker, but anything except of SIOCSVH :)

P.S. Abbreviation "hw" might also be improved.

-- 
Totus tuus, Glebius.