From owner-freebsd-current@FreeBSD.ORG  Sun Jun 11 12:54:17 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B31B716A41A
	for <current@freebsd.org>; Sun, 11 Jun 2006 12:54:17 +0000 (UTC)
	(envelope-from marius.nuennerich@gmx.net)
Received: from mail.gmx.net (mail.gmx.de [213.165.64.21])
	by mx1.FreeBSD.org (Postfix) with SMTP id 2E6F843D77
	for <current@freebsd.org>; Sun, 11 Jun 2006 12:54:07 +0000 (GMT)
	(envelope-from marius.nuennerich@gmx.net)
Received: (qmail invoked by alias); 11 Jun 2006 12:54:05 -0000
Received: from pD9ECC9D2.dip0.t-ipconnect.de (EHLO sol.hackerzberg.local)
	[217.236.201.210]
	by mail.gmx.net (mp001) with SMTP; 11 Jun 2006 14:54:05 +0200
X-Authenticated: #5707313
Date: Sun, 11 Jun 2006 14:53:51 +0200
From: Marius Nuennerich <marius.nuennerich@gmx.net>
To: current@freebsd.org
Message-ID: <20060611145351.221ec001@sol.hackerzberg.local>
X-Mailer: Sylpheed-Claws 2.2.2 (GTK+ 2.8.18; i386-portbld-freebsd6.1)
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_=gzHPlWNL+3VOEIdNbLqHKY"
X-Y-GMX-Trusted: 0
X-Mailman-Approved-At: Sun, 11 Jun 2006 13:05:38 +0000
Cc: John Birrell <jb@what-creek.com>
Subject: DTrace SDT Provider not working?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Jun 2006 12:54:17 -0000

--MP_=gzHPlWNL+3VOEIdNbLqHKY
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi John, all!

I tried to add the SDT Hooks for callout(9), see attached patch.
> # dtrace -l -f callout
>    ID   PROVIDER            MODULE                          FUNCTION NAME
>     6        sdt            kernel                           callout entry
>     7        sdt            kernel                           callout return

however, a simple

> # dtrace -n 'sdt:kernel:callout:entry{printf("1");}'

prints that a probe is matched but nothing else, same for
sdt:kernel:linker_load_module:entry and kldload'ing a module.

I use the snapshot code you provided.

Any idea where to look next?

Thank you very much for your work!
regards
Marius
--MP_=gzHPlWNL+3VOEIdNbLqHKY
Content-Type: text/x-patch; name=kern_timeout.c.diff
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=kern_timeout.c.diff

--- kern_timeout.c.orig	Sun Jun 11 13:18:07 2006
+++ kern_timeout.c	Sun Jun 11 13:31:04 2006
@@ -45,6 +45,7 @@
 #include <sys/ktr.h>
 #include <sys/lock.h>
 #include <sys/mutex.h>
+#include <sys/sdt.h>
 #include <sys/proc.h>
 #include <sys/sysctl.h>

@@ -268,7 +269,9 @@
 				binuptime(&bt1);
 #endif
 				THREAD_NO_SLEEPING();
+				SDT_PROBE(kernel, callout, entry, c, 0, 0, 0, 0);
 				c_func(c_arg);
+				SDT_PROBE(kernel, callout, return, c, 0, 0, 0, 0);
 				THREAD_SLEEPING_OK();
 #ifdef DIAGNOSTIC
 				binuptime(&bt2);

--MP_=gzHPlWNL+3VOEIdNbLqHKY--