Date: Mon, 13 Jun 2005 12:00:36 -0400 From: Josh Kayse <josh.kayse@gmail.com> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: freebsd-net@freebsd.org, freebsd-pf@freebsd.org Subject: Re: Carp Suppression Message-ID: <7c8f2792050613090040c924c3@mail.gmail.com> In-Reply-To: <20050613153550.GA54388@comp.chem.msu.su> References: <7c8f2792050610090049064e11@mail.gmail.com> <7c8f279205061116021f55e8da@mail.gmail.com> <7c8f279205061307103b1782f4@mail.gmail.com> <20050613153550.GA54388@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
Definitely a typo on my part. It should be ifp->if_link_state =3D LINK_STATE_UP The reason we are using CARP on a PLIP interface is to allow us to have redundant connections between 2 transparent bridging firewalls.=20 Instead of sending packets over our network, we isolate them onto a PLIP interface and crossover interface. We then use ifstaded to monitor the carp interfaces and shut down bridging on one of the machines. I will refrain from submitting any code to the community in the future. On 6/13/05, Yar Tikhiy <yar@comp.chem.msu.su> wrote: > On Mon, Jun 13, 2005 at 10:10:54AM -0400, Josh Kayse wrote: > > One last comment, > > > > I managed to fix it so that carp runs on the plip interface by adding: > > ifp->if_flags =3D LINK_STATE_UP; > > > > Here is the diff: > > > > diff -Nur /usr.orig/src/sys/dev/ppbus/if_plip.c /usr/src/sys/dev/ppbus/= if_plip.c > > --- /usr.orig/src/sys/dev/ppbus/if_plip.c Wed Sep 15 11:14:18 200= 4 > > +++ /usr/src/sys/dev/ppbus/if_plip.c Mon Jun 13 10:05:56 2005 > > @@ -359,6 +359,7 @@ > > > > ppb_wctr(ppbus, IRQENABLE); > > ifp->if_flags |=3D IFF_RUNNING; > > + ifp->if_flags =3D LINK_STATE_UP; > > } > > break; >=20 > I'm afraid you're totally wrong here. >=20 > First, I can't see how CARP is supposed to work on a PLIP interface > or any point-to-point interface at all. CARP is for broadcast > interfaces, such as Ethernet or FDDI, which do ARP. You seem to miss > the point. >=20 > Second, you can't store an arbitrary value into a variable or field > and expect the things to work right. LINK_STATE_UP simply is not for > ifp->if_flags. Please make yourself familiar with the basics of > computer programming before offering your patches to the community. >=20 > -- > Yar >=20 --=20 Joshua Kayse Computer Engineering
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7c8f2792050613090040c924c3>