From owner-freebsd-ports  Sat Apr 18 09:20:07 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id JAA07211
          for freebsd-ports-outgoing; Sat, 18 Apr 1998 09:20:07 -0700 (PDT)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id JAA07185;
          Sat, 18 Apr 1998 09:20:03 -0700 (PDT)
          (envelope-from gnats)
Received: from indigo.ie (nsmart@ts01-51.waterford.indigo.ie [194.125.139.114])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA05288
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Apr 1998 16:13:02 GMT
          (envelope-from nsmart@indigo.ie)
Received: (from nsmart@localhost)
	by indigo.ie (8.8.8/8.8.7) id RAA10815;
	Sat, 18 Apr 1998 17:11:35 +0100 (IST)
	(envelope-from nsmart)
Message-Id: <199804181611.RAA10815@indigo.ie>
Date: Sat, 18 Apr 1998 17:11:35 +0100 (IST)
From: rotel@indigo.ie
Reply-To: rotel@indigo.ie
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: ports/6341: make install uses ``make'' instead of ${MAKE} causing package registration to fail
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         6341
>Category:       ports
>Synopsis:       make install uses ``make'' instead of ${MAKE} causing package registration to fail
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 18 09:20:02 PDT 1998
>Last-Modified:
>Originator:     Niall Smart
>Organization:
None
>Release:        FreeBSD 2.2.6-STABLE i386
>Environment:

>Description:

On my system /usr/local/bin/make is a symlink to /usr/local/bin/gmake,
/usr/local/bin/pmake is a symlink to /usr/bin/make and /usr/local/bin
comes before /usr/bin in my PATH.  Therefore ``make'' executes GNU
make and ``pmake'' executes PMake.

When installing a port I ``pmake all install'', however since
bsd.port.mk executes ``make'' instead of ``${MAKE}'' in some places,
package registration fails GNU make is invoked and it doesn't grok
the Makefiles used in the ports system

>How-To-Repeat:

$ cd /usr/local/bin
$ ln gmake make
$ ln -s /usr/bin/make pmake
$ cd /usr/ports/lang/perl
$ PATH=/usr/local/bin:$PATH pmake all install
 
[...]
 
===>   Compressing manual pages for perl-5.00404
===>  Registering installation for perl-5.00404
Makefile:70: *** missing separator.  Stop.
$

>Fix:
	
Fix bsd.port.mk to use ${MAKE} instead of make by applying this patch:


*** bsd.port.mk	Mon Mar 30 19:34:32 1998
--- /root/bsd.port.mk	Sat Apr 18 16:53:19 1998
***************
*** 1711,1713 ****
  		ABCDE) ;; \
! 		*) cd ${.CURDIR} && ${ECHO} -n `make depends-list|sort -u`;; \
  	esac; \
--- 1711,1713 ----
  		ABCDE) ;; \
! 		*) cd ${.CURDIR} && ${ECHO} -n `${MAKE} depends-list|sort -u`;; \
  	esac; \
***************
*** 1716,1718 ****
  		ABCD) ;; \
! 		*) cd ${.CURDIR} && ${ECHO} -n `make package-depends|sort -u`;; \
  	esac; \
--- 1716,1718 ----
  		ABCD) ;; \
! 		*) cd ${.CURDIR} && ${ECHO} -n `${MAKE} package-depends|sort -u`;; \
  	esac; \
***************
*** 1747,1749 ****
  	@${ECHO} -n 'This port requires package(s) "'
! 	@${ECHO} -n `make depends-list | sort -u`
  	@${ECHO} '" to build.'
--- 1747,1749 ----
  	@${ECHO} -n 'This port requires package(s) "'
! 	@${ECHO} -n `${MAKE} depends-list | sort -u`
  	@${ECHO} '" to build.'
***************
*** 1756,1758 ****
  	@${ECHO} -n 'This port requires package(s) "'
! 	@${ECHO} -n `make package-depends | sort -u`
  	@${ECHO} '" to run.'
--- 1756,1758 ----
  	@${ECHO} -n 'This port requires package(s) "'
! 	@${ECHO} -n `${MAKE} package-depends | sort -u`
  	@${ECHO} '" to run.'
***************
*** 1790,1792 ****
  		fi; \
! 		for dep in `make package-depends ECHO_MSG=/usr/bin/true | sort -u`; do \
  			if [ -d ${PKG_DBDIR}/$$dep ]; then \
--- 1790,1792 ----
  		fi; \
! 		for dep in `${MAKE} package-depends ECHO_MSG=/usr/bin/true | sort -u`; do \
  			if [ -d ${PKG_DBDIR}/$$dep ]; then \
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message