Date: Sun, 5 Aug 2007 17:13:48 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Gabor Kovesdan <gabor@FreeBSD.org> Cc: ports@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: PORTSDIR use-before-define fix Message-ID: <20070805211348.GA24361@rot26.obsecurity.org> In-Reply-To: <46B637AA.1040001@FreeBSD.org> References: <20070805055340.GA11899@rot26.obsecurity.org> <46B637AA.1040001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 05, 2007 at 10:48:42PM +0200, Gabor Kovesdan wrote:
> Kris Kennaway escribi?:
> >Previous DESTDIR commits introduced dereferences of ${PORTSDIR} before
> >it was set (via .include), which broke e.g. portmaster. This diff
> >shuffles some things around to hopefully restore everything to being
> >defined before it is used. It also cleans up some stale cruft. It
> >has only been lightly tested.
> >
> >
> I haven't tested it yet, but it seems good to me. Thanks for working on
> this! I'll test it a bit next
> day. What about COMMENTFILE? I see it was removed, but can't see it
> added back. Is it
> completely obsolete?
Yes, for 3 years now :)
Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070805211348.GA24361>