Date: Mon, 18 Jan 1999 12:56:23 +0200 From: Sheldon Hearn <axl@iafrica.com> To: Joseph Koshy <jkoshy@FreeBSD.ORG> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/audio/mpg123/patches patch-aa Message-ID: <4867.916656983@axl.noc.iafrica.com> In-Reply-To: Your message of "Thu, 14 Jan 1999 21:34:04 PST." <199901150534.VAA17000@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Jan 1999 21:34:04 PST, Joseph Koshy wrote: > jkoshy 1999/01/14 21:34:03 PST > > Modified files: > audio/mpg123/patches patch-aa > Log: > Honor CFLAGS. > > PR: ports/9488 > Submitted by: Sheldon Hearn <axl@iafrica.com> > Reviewed by: jkoshy Hi Joseph, You don't seem to have applied my patch as submitted. That's not usually a problem ;), except that what you've applied produces different results from what I'd intended. The patch-aa file now sets up the following: CFLAGS+='$(CFLAGS) -Wall -O2 [...]' This means that stronger otpimization than I may want will be imposed on me. If you insist on keeping -O2 in place as a default, may I suggest you do it as follows: CFLAGS+='-Wall -O2 [...] $(CFLAGS)' This means that my '-O' will override the default -O2. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4867.916656983>