From owner-svn-ports-head@FreeBSD.ORG Fri Mar 27 01:50:55 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 37939E28; Fri, 27 Mar 2015 01:50:55 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 39853CE6; Fri, 27 Mar 2015 01:50:54 +0000 (UTC) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id c040c6d0; TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO; Thu, 26 Mar 2015 19:50:45 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r382355 - head/graphics/entangle From: Adam Weinberger In-Reply-To: <20150327014129.GA35030@FreeBSD.org> Date: Thu, 26 Mar 2015 19:50:37 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201503262330.t2QNUq3H058554@svn.freebsd.org> <20150327014129.GA35030@FreeBSD.org> To: Ben Woods X-Mailer: Apple Mail (2.2070.6) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger , Alexey Dokuchaev , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 01:50:55 -0000 Copying in Ben here. If itstool is in fact just a build-time dependency, some of the patterns = you have available are RUN_DEPENDS:=3D ${BUILD_DEPENDS} BUILD_DEPENDS+=3D ... or RUN_DEPENDS:=3D ${BUILD_DEPENDS:Nitstool*} or BUILD_DEPENDS:=3D ${RUN_DEPENDS} itstool:... Though, as Alexey noted, that last one just looks weird. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org > On 26 Mar, 2015, at 19:41, Alexey Dokuchaev wrote: >=20 > On Thu, Mar 26, 2015 at 11:30:52PM +0000, Adam Weinberger wrote: >> New Revision: 382355 >> URL: https://svnweb.freebsd.org/changeset/ports/382355 >> QAT: https://qat.redports.org/buildarchive/r382355/ >>=20 >> Log: >> Update graphics/entangle to 0.7.0, and assign maintainership to >> submitter (Ben Woods). >=20 > Nice, I've been waiting for a while to someone to grab this from me. = Having > to install gtk3 everytime I was working on an update was a PITA. >=20 >> -BUILD_DEPENDS=3D = ${LOCALBASE}/share/icons/mate/scalable/devices/camera-photo-symbolic.svg:$= {PORTSDIR}/x11-themes/mate-icon-theme >> +BUILD_DEPENDS=3D = ${LOCALBASE}/share/icons/mate/scalable/devices/camera-photo-symbolic.svg:$= {PORTSDIR}/x11-themes/mate-icon-theme \ >> + itstool:${PORTSDIR}/textproc/itstool >> LIB_DEPENDS=3D libgphoto2.so:${PORTSDIR}/graphics/libgphoto2 \ >> libdbus-glib-1.so:${PORTSDIR}/devel/dbus-glib \ >> liblcms2.so:${PORTSDIR}/graphics/lcms2 \ >> @@ -20,10 +21,13 @@ LIB_DEPENDS=3D libgphoto2.so:${PORTSDIR}/g >> libpeas-1.0.so:${PORTSDIR}/devel/libpeas >> RUN_DEPENDS:=3D ${BUILD_DEPENDS} >=20 > Isn't itstool(1) a build-time only tool? If so, it means that = BUILD_DEPENDS > is no longer equal to RUN_DEPENDS, so I think they have to be set = explicitly > now. Alternatively, you can first set RUN_DEPENDS (mate-icon-theme), = then > assign BUILD_DEPENDS:=3D ${RUN_DEPENDS} = itstool:${PORTSDIR}/textproc/itstool, > but it's kind of in bogus order, we probably should not encourage = this. >=20 > ./danfe >=20