From owner-svn-src-all@freebsd.org Mon Jun 10 14:57:59 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 646FB15C1757; Mon, 10 Jun 2019 14:57:59 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA0FE76D4D; Mon, 10 Jun 2019 14:57:58 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: by mail-ot1-x342.google.com with SMTP id r10so8576841otd.4; Mon, 10 Jun 2019 07:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OV8FWWL8HIgUlN+Zo0fZow/rI+SxGtVYRxTa4qTFQ2Q=; b=Atml7IEPRY0d5EPcb2fdQ+FmT4DpkpiumLvCZgXX3zqqQIIvJyfn0/IelaoolpK2vr ZVKGSTVPGuODWlfbhvhSGfteVvdxjIeUV0ho7d2XQivvd6ZG8B1wlDy4xI+FIfWTjBhr qb4aFmc62E35edIYbOVdt+3iXOq9ODmaRXVYqxdAnaKSdK5wTdPJ26wY0ftObfoCCPG5 hnLLWnJgsEAKr3QFFZxK2SrP4veGp/oc11t6Oz1zOt8Jz39uSy2F8UodBr9uip+J7lN2 /TenLHRuvbi2KIJbNdUU2wou33sUmVNzId6fMu2niv/nX/roQ1dAyxk/UZrZt7iLbLQV jJLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=OV8FWWL8HIgUlN+Zo0fZow/rI+SxGtVYRxTa4qTFQ2Q=; b=CyLKg7o+YBLwjGhomxmUDF7mvyJ6mt9m2VnmEjhIdv3wawQxr0ZaMFeadWD2bTBfLO XKdE3XSPhgHAdmBndeSwSEw8xHVYLtqfexPXB1ynUMO89zbJJO2KN0dkDVJzDlLI6dk6 a4mQiz8ZDiWqDxDOm3XXi8N57cCGbYmQ7aSfYRgGAZhSK03f4H4P5Wsz0ghqC7WNmj6J woQ7WurpDBw7O5EuFDsSTUcJQomiHVPWT5JnrXcx753RGkEHaQbxjzwQ3zUqG+GDqIOV IJ9qaNoLDVc8DO/O1wiEddCmAwzY3b9k6+Y2mUpfiE+RzI+v40gDBZpsi3vQ2z8EP2cY 1K/Q== X-Gm-Message-State: APjAAAXYRXIWblSt14rG+8EcHKhGmIDdUGTQyCVUsjPLjhtwTbHqMhbN bKx9sGF6/ERpwyWYTb6g0aRNAU7nV+U= X-Google-Smtp-Source: APXvYqwtZAyVMim/gUZ2/zlRGJRA3CuobgjOYaNNlU8LbvLmxrZEqDChMAmSu26+rUrrAipr+iIQtw== X-Received: by 2002:a05:6830:148c:: with SMTP id s12mr1920281otq.274.1560178677827; Mon, 10 Jun 2019 07:57:57 -0700 (PDT) Received: from 108-254-203-202.lightspeed.hstntx.sbcglobal.net (108-254-203-202.lightspeed.hstntx.sbcglobal.net. [108.254.203.202]) by smtp.gmail.com with ESMTPSA id s64sm4084029oie.40.2019.06.10.07.57.57 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2019 07:57:57 -0700 (PDT) Subject: Re: svn commit: r348843 - head/sys/vm To: Shawn Webb Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, pho@freebsd.org References: <201906100307.x5A37BFt099669@repo.freebsd.org> <20190610130034.k2nzitvaxvpj5lzx@mutt-hbsd> <20190610142715.be254wljfrnetuom@mutt-hbsd> From: Doug Moore Openpgp: preference=signencrypt Autocrypt: addr=unkadoug@gmail.com; keydata= mQENBFy53VQBCAD2UiGSouAAMcSIax5Sp9JtRSd9dYVuAmSraY7x5yOylq8yJ5IDvHZy5q3a FamaCHMpXxieiD/8yTnHIeHP4bg02oDD3ALs0hMAEz00pZlLdxeXRfDzAlMTqFF6USPjDUI8 J/WH+pciNT68bFVXFYVg+bgp4GIdi2Md8X8zQQnHY0xLyKE9FjVN1MlCk+62B6fFhMQIEvd5 RQdbGd+ljuoORD1ajljwP1waXKBfAN5RnIbAXppokgQvnwNRf1eZ7GnqSiwu0eaTHGBatPgr y2v5N19R5WxP2kiN95xdlJEwdUikAhWO1UncDxvXQoM1e68L/J85JSLLIgzuywKpBBtdABEB AAG0MERvdWcgTW9vcmUgKHd3dy5mcmVlYnNkLm9yZykgPGRvdWdtQGZyZWVic2Qub3JnPokB UgQTAQoAPBYhBHleNTGSVgOuQpfeg+iPIVPTudVuBQJcyljBAhsDBQkFo5qAAwsJCAUVCgkI CwUWAwIBAAIeAQIXgAAKCRDojyFT07nVbs4lB/49oHwi3YR7SQr43+59tBudmf3WdQ1SRi3G vJDufsrtsB7E9bIFXwFGvVDOMn/cfhNlzors3aM6UQr1N3TPqMAK4TaS12qGL3EvFQ0eVAF1 J+vhQCIjZtgFaCIjoPeQVbi2tVsHaCttBRJeHRIPruWlxngSGZ7eMfjlOY9Oupi809QjFO/3 7FHv+/Bw9HvzlUciY3wH6vLe4zE3Bhqz4lrQAAKey4XPwKwUgs7QK0qhHrlxy+mD0r8LYvwE +Y7WVu5bbDPbyWYZeI8rnCCKnoJ7VFxQd2/g3Jxc1alDg5LoHCssP7z8g9OG8GBXk1T5dRrA Vxlc8Rs3gSxg6b3+lt+CuQENBFy53VQBCADbHDoIQCMsyFFaNjzqZbrd8ntaMwpQ6hBL7Rnb LJSHa8jehZYyAdtWWbbttyVf66J3EAF6HyBXExw9fryuLU+yZfANI0D3cmmb51jCG6Bu8Nnk QTOf3N7cw1sYQSHH2PQlhWYc55Jbu/aJrwfVnEchLdbN8p2y4WXRLfhK32iOaQzMM2xHNk28 sXnAV5DRxQjvXY7IG7cT5Pfr2uAhXqPDDCZsMj9ghZ3aQyvr7q7jS1uzvSPsimOW4Hf9fJqi VxF2kMRH1hQNe1I4v79SaFtDXRSuYivEPV6epifWATwY66/U/jO55TqqDyFz/Bg+2CCpHyyZ GM9A+f86VxLEGc7hABEBAAGJATwEGAEIACYWIQR5XjUxklYDrkKX3oPojyFT07nVbgUCXLnd VAIbDAUJBaOagAAKCRDojyFT07nVbkhiB/0SVq6YcYwrz1j1lBUk7DCUPVALoNSiW4iNia52 7pWQdHGtsTVVCiEcB65qZo0DSrMsAvtGCRSzUebIQ6omDSDnWmbveXykr3vO0+pcRqsJPQKc ATRq2XjcBjZMKOD4A2XOS2t3hAM+oY4F9htQIY9gnvK6RdTtyafJonHpeeNkMC7KEwPGS6hz FU0lrfZxXQ1ipj0QOOgZ8ZomMXbSV5f8GwYSULMPOVmB9ak0ZCOoa451h0o3Hjcnrngw7ofF JFPbmPT2zbpXOm9PqshzTA10ngIETm2x4j5iVvCHEbOJCH8UQydNKrGFa3UBzqj1OoxAggqh CFx6S9PsRfm6+86cuQENBFy6y/MBCAC+ULdDmJZVs7GFnpBdKJnSnVIbX1dkGju1jkvg+7pA 82yX+0hZvIOh0x3Py8asbfqxFleVws59mGEAe5YpRyg+kn0fd14ethlIrsf0sG82b7QLyf9p xGuQBlhyHvgDgdeUGlz6kybVJ9e59ebtNYgjuEC/Glf/b55pmmkSXx5F/4l82Er7fhpiOg42 n7CLonP+AxLsR8L6AjCODedyKidSopcdH8dH6RTN9CmIYSPQq8vRiARrDLNvVQH4PQlv3s4C KqP6zSN3hMdLlLtvgd6UMdyuWKxRk0y0WhGa4bZ8oKPCo5Dr6o12OSEvx+Ue2QBQ67nVY5H6 SoCoopHHomeRABEBAAGJAtIEGAEKACYWIQR5XjUxklYDrkKX3oPojyFT07nVbgUCXLrL8wIb AgUJBaOagAGgCRDojyFT07nVbsDUIAQZAQoAfRYhBH6QdtAAogUD++RrUKO0e1Y/oUusBQJc usvzXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9wZW5wZ3AuZmlmdGhob3JzZW1h bi5uZXQ3RTkwNzZEMDAwQTIwNTAzRkJFNDZCNTBBM0I0N0I1NjNGQTE0QkFDAAoJEKO0e1Y/ oUusp/AH/0kmG5bylgh6Crg307jXoCQgZvtThaB9LGmf57ypUvnfrwt1n0Ex7cKcQnvSA+12 809K12QmR5D61AdU8HBaQdoLFj0rDi34raxgAY554+YiGuj9XagPEKMeb+iuvqvhetC6v7K8 eXqpaWIozIpFJCmElxGMSngAj/V6nOnm6XDSyfgaOCmnjOQRqe49uU+6R67gb7UB4J+XJHgP Wla91BTqsv3NLcwXINqP+iiHtgMLmrH1j0eNhxOk9+RLNf0YbZcGZHf7eWjcJbWcB13e0gF6 mR0RcQxClm89EVv2p+CPITpXTALrIb1/EX9O4bz9OuzdZk5FrWAUNHStBE6+McJz9Qf9Hs+Z vDizuv8NOX2YZeKRdBpWSsKRL32DkPrup6vMDVL1LIft3SJXLc+oWvy82fAm0HuGMXHq47Zc bvmHUJfnSrdhjHSB35R3BwzYZ4/lINDR90WgKw+NJNErmiIP3oPzlVNtLsQmAXXjAdysFuq6 VSW0TclJVIiBjLgnKvh0XzakzxdZ5pVpgCHzKggO+53lRhEkQIgLTRU0bVb/BQkqa8iGwUhB dGd4Sgy9sykO8/1C8ApYrsT51iG7956YWG14NOBuHXoBsdynCTAVYwSR7+7f3enNKzEpUKtg ALG/tpjXzp8gsOtBSlComvjQjZHfWe9+fLy2wJ98wi8q0n3xHA== Message-ID: <65cab520-731a-3256-8a71-bb8cfcc93011@gmail.com> Date: Mon, 10 Jun 2019 09:57:56 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190610142715.be254wljfrnetuom@mutt-hbsd> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: BA0FE76D4D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.963,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 14:57:59 -0000 The comment and the code that rejects size=3D=3D0, or doesn't, are copied= below.=A0 Konstantin Belousov is the last person to have touched most of it, and can better explain its meaning than I. Doug Moore =A0=A0=A0 /* =A0=A0=A0 =A0* Enforce the constraints. =A0=A0=A0 =A0* Mapping of length 0 is only allowed for old binaries. =A0=A0=A0 =A0* Anonymous mapping shall specify -1 as filedescriptor and =A0=A0=A0 =A0* zero position for new code. Be nice to ancient a.out =A0=A0=A0 =A0* binaries and correct pos for anonymous mapping, since old =A0=A0=A0 =A0* ld.so sometimes issues anonymous map requests with non-zer= o =A0=A0=A0 =A0* pos. =A0=A0=A0 =A0*/ =A0=A0=A0 if (!SV_CURPROC_FLAG(SV_AOUT)) { =A0=A0=A0 =A0=A0=A0 if ((size =3D=3D 0 && curproc->p_osrel >=3D P_OSREL_M= AP_ANON) || =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 ((flags & MAP_ANON) !=3D 0 && (fd !=3D -1 |= | pos !=3D 0))) =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 return (EINVAL); =A0=A0=A0 } else { =A0=A0=A0 =A0=A0=A0 if ((flags & MAP_ANON) !=3D 0) =A0=A0=A0 =A0=A0=A0 =A0=A0=A0 pos =3D 0; =A0=A0=A0 } On 6/10/19 9:27 AM, Shawn Webb wrote: > Sounds good! I think the manpage still might still need a change > to match the current behavior, or perhaps matching something similar > to that vm_mmap.c comment. But that comment brings another question: > what's the definition of "old binaries"? a.out? > > Thanks, >