Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Feb 2013 12:16:35 -0800
From:      Xin Li <delphij@delphij.net>
To:        delphij@FreeBSD.org
Cc:        freebsd-ports-bugs@FreeBSD.org, gasol.wu@gmail.com
Subject:   Re: ports/176320: [NEW PORT] devel/php5-ZendOptimizerPlus: Faster PHP opcode caching and optimization
Message-ID:  <5127D223.7070204@delphij.net>
In-Reply-To: <201302221900.r1MJ0ige080355@freefall.freebsd.org>
References:  <201302221900.r1MJ0ige080355@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------020707000603070502060504
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

There are multiple issues with the original patch.  I'm going to
commit this version if the Mk part was approved by the maintainer (ale@).

Cheers,
- -- 
Xin LI <delphij@delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJRJ9IjAAoJEG80Jeu8UPuzWnsH/2id1v7jFrQ2Ez3QcowbZM8X
IG54TPzWToL3ncxmw5xdNAXCpoRUWEJy9sVG7+hAC5xwUd3uQgn2ceQUHED7Oiim
pyFxfe8zO+XMprlpsWn0w1B3G+HwvljH/akmsvxLPJiJY2dBuPXLL+nWebX1HJTG
1RBAe61kCaLaF5UukH2u5houbSbd6ncAPuBYyrLTpoOktH7q80C6potvNf453jr8
ZHhzS/D6Mhi0FBGCWyW/LbM7uSPB3DolpJFKjW41Zauoyagfcq8Rq9xpm8yU5278
BF4xsqtrq2KwqLzKzZjE4eTQ9NuTNHr17zAl6jlQqxsrT5vNvOw6yQ0HYrlA6YM=
=R9NY
-----END PGP SIGNATURE-----

--------------020707000603070502060504
Content-Type: text/plain; charset=UTF-8;
 name="ZendOptimizerPlus.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="ZendOptimizerPlus.diff"

Index: Mk/bsd.php.mk
===================================================================
--- Mk/bsd.php.mk	(revision 312787)
+++ Mk/bsd.php.mk	(working copy)
@@ -168,6 +168,9 @@ do-phpize:
 .if defined(_POSTMKINCLUDED) && defined(USE_PHPEXT)
 PHP_MODNAME?=	${PORTNAME}
 PHP_HEADER_DIRS?=	""
+.if ${PHP_MODNAME} == "ZendOptimizerPlus"
+_PHP_ZEND_EXTENSION=	yes
+.endif
 
 do-install:
 	@${MKDIR} ${PREFIX}/lib/php/${PHP_EXT_DIR}
@@ -184,8 +187,13 @@ do-install:
 	@${ECHO_CMD} \#include \"ext/${PHP_MODNAME}/config.h\" \
 		>> ${PREFIX}/include/php/ext/php_config.h
 	@${MKDIR} ${PREFIX}/etc/php
+.if !defined(_PHP_ZEND_EXTENSION)
 	@${ECHO_CMD} extension=${PHP_MODNAME}.so \
 		>> ${PREFIX}/etc/php/extensions.ini
+.else
+	@${ECHO_CMD} zend_extension=${PREFIX}/lib/php/${PHP_EXT_DIR}/${PHP_MODNAME}.so \
+		>> ${PREFIX}/etc/php/extensions.ini
+.endif
 
 add-plist-info: add-plist-phpext
 add-plist-phpext:
@@ -207,12 +215,22 @@ add-plist-phpext:
 		>> ${TMPPLIST}
 	@${ECHO_CMD} "@exec mkdir -p %D/etc/php" \
 		>> ${TMPPLIST}
+.if !defined(_PHP_ZEND_EXTENSION)
 	@${ECHO_CMD} "@exec echo extension=${PHP_MODNAME}.so >> %D/etc/php/extensions.ini" \
 		>> ${TMPPLIST}
+.else
+	@${ECHO_CMD} "@exec echo zend_extension=%D/lib/php/${PHP_EXT_DIR}/${PHP_MODNAME}.so >> %D/etc/php/extensions.ini" \
+		>> ${TMPPLIST}
+.endif
 	@${ECHO_CMD} "@unexec cp %D/etc/php/extensions.ini %D/etc/php/extensions.ini.orig" \
 		>> ${TMPPLIST}
+.if !defined(_PHP_ZEND_EXTENSION)
 	@${ECHO_CMD} "@unexec grep -v extension=${PHP_MODNAME}\\\.so %D/etc/php/extensions.ini.orig > %D/etc/php/extensions.ini || true" \
 		>> ${TMPPLIST}
+.else
+	@${ECHO_CMD} "@unexec grep -v zend_extension=%D/lib/php/${PHP_EXT_DIR}/${PHP_MODNAME}\\\.so %D/etc/php/extensions.ini.orig > %D/etc/php/extensions.ini || true" \
+		>> ${TMPPLIST}
+.endif
 	@${ECHO_CMD} "@unexec rm %D/etc/php/extensions.ini.orig" \
 		>> ${TMPPLIST}
 	@${ECHO_CMD} "@unexec [ -s %D/etc/php/extensions.ini ] || rm %D/etc/php/extensions.ini" \
@@ -228,7 +246,11 @@ php-ini:
 	@${ECHO_CMD} "The following line has been added to your ${PREFIX}/etc/php/extensions.ini"
 	@${ECHO_CMD} "configuration file to automatically load the installed extension:"
 	@${ECHO_CMD} ""
+.if !defined(_PHP_ZEND_EXTENSION)
 	@${ECHO_CMD} "extension=${PHP_MODNAME}.so"
+.else
+	@${ECHO_CMD} "zend_extension=${PREFIX}/lib/php/${PHP_EXT_DIR}/${PHP_MODNAME}.so"
+.endif
 	@${ECHO_CMD} ""
 	@${ECHO_CMD} "****************************************************************************"
 .endif
Index: devel/Makefile
===================================================================
--- devel/Makefile	(revision 312787)
+++ devel/Makefile	(working copy)
@@ -29,6 +29,7 @@
     SUBDIR += R-cran-reshape2
     SUBDIR += SpecTcl
     SUBDIR += ZendOptimizer
+    SUBDIR += ZendOptimizerPlus
     SUBDIR += aap
     SUBDIR += abi-compliance-checker
     SUBDIR += ace
Index: devel/ZendOptimizerPlus/Makefile
===================================================================
--- devel/ZendOptimizerPlus/Makefile	(revision 0)
+++ devel/ZendOptimizerPlus/Makefile	(working copy)
@@ -0,0 +1,31 @@
+# Created by: Gasol Wu <gasol.wu@gmail.com>
+# $FreeBSD$
+
+PORTNAME=	ZendOptimizerPlus
+PORTVERSION=	0.0.20130220
+CATEGORIES=	devel
+DISTNAME=	${GH_ACCOUNT}-${GH_PROJECT}-${GH_COMMIT}
+
+MAINTAINER=	gasol.wu@gmail.com
+COMMENT=	Faster PHP opcode caching and optimization
+
+USE_GITHUB=	yes
+GH_ACCOUNT=	zend-dev
+GH_TAGNAME=	280bbaf
+GH_COMMIT=	${GH_TAGNAME}
+
+CONFLICTS_INSTALL=	ZendOptimizer-*
+
+CONFIGURE_ARGS=	--enable-optimizer-plus
+USE_PHP=	yes
+USE_PHPEXT=	yes
+USE_PHP_BUILD=	yes
+SUB_FILES=	pkg-message
+SUB_LIST+=	PHP_MODNAME=${PHP_MODNAME}
+
+PKGMESSAGE=	${WRKDIR}/pkg-message
+
+post-install:
+	@${CAT} ${PKGMESSAGE}
+
+.include <bsd.port.mk>

Property changes on: devel/ZendOptimizerPlus/Makefile
___________________________________________________________________
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: svn:keywords
## -0,0 +1 ##
+FreeBSD=%H
\ No newline at end of property
Index: devel/ZendOptimizerPlus/distinfo
===================================================================
--- devel/ZendOptimizerPlus/distinfo	(revision 0)
+++ devel/ZendOptimizerPlus/distinfo	(working copy)
@@ -0,0 +1,2 @@
+SHA256 (zend-dev-ZendOptimizerPlus-280bbaf.tar.gz) = 9fd7633c5a0c8185815f5bfd273f6b71aa7ecbd6695677977ba901fb7cb981cd
+SIZE (zend-dev-ZendOptimizerPlus-280bbaf.tar.gz) = 80134

Property changes on: devel/ZendOptimizerPlus/distinfo
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Index: devel/ZendOptimizerPlus/files/pkg-message.in
===================================================================
--- devel/ZendOptimizerPlus/files/pkg-message.in	(revision 0)
+++ devel/ZendOptimizerPlus/files/pkg-message.in	(working copy)
@@ -0,0 +1,9 @@
+****************************************************************************
+
+NOTE:
+
+In case you are going to use Zend Optimizer+ together with Xdebug,
+be sure that Xdebug is loaded after Optimizer+. "php -v" must show Xdebug
+after Optimizer+.
+
+****************************************************************************

Property changes on: devel/ZendOptimizerPlus/files/pkg-message.in
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: devel/ZendOptimizerPlus/pkg-descr
===================================================================
--- devel/ZendOptimizerPlus/pkg-descr	(revision 0)
+++ devel/ZendOptimizerPlus/pkg-descr	(working copy)
@@ -0,0 +1,7 @@
+The Zend Optimizer+ provides faster PHP execution through opcode caching and
+optimization. It improves PHP performance by storing precompiled script
+bytecode in the shared memory. This eliminates the stages of reading code from
+the disk and compiling it on future access. In addition, it applies a few
+bytecode optimization patterns that make code execution faster.
+
+WWW: https://github.com/zend-dev/ZendOptimizerPlus/

Property changes on: devel/ZendOptimizerPlus/pkg-descr
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property

--------------020707000603070502060504--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5127D223.7070204>