Date: Thu, 14 Jul 2005 16:51:45 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20050714125145.GA18744@cell.sick.ru> In-Reply-To: <20050714083608.A21239@grasshopper.cs.duke.edu> References: <200507131406.j6DE6DLv066313@repoman.freebsd.org> <20050714083608.A21239@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 14, 2005 at 08:36:08AM -0400, Andrew Gallatin wrote: A> Gleb Smirnoff [glebius@FreeBSD.org] wrote: A> > glebius 2005-07-13 14:06:13 UTC A> > A> > FreeBSD src repository A> > A> > Modified files: A> > sys/pci if_xl.c A> > Log: A> > NET_LOCK_GIANT() when entering network code. A> > A> A> Do other drivers do this? It looks like at least em, fxp A> and my out-of-tree commercial driver have the same "bug". They do. Look at if_ath.c:ath_rx_proc(). This is done in functions that execute from a separate context - from task queue. em, fxp and others may not have such functions. A> I would argue that any fiddling with Giant should go into A> the various if_input routines instead. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050714125145.GA18744>