From owner-svn-ports-all@FreeBSD.ORG Sun Jul 28 20:35:01 2013 Return-Path: Delivered-To: svn-ports-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 73EC9750; Sun, 28 Jul 2013 20:35:01 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from monday.kientzle.com (99-115-135-74.uvs.sntcca.sbcglobal.net [99.115.135.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 40BF1298F; Sun, 28 Jul 2013 20:35:00 +0000 (UTC) Received: (from root@localhost) by monday.kientzle.com (8.14.4/8.14.4) id r6SKYxrg093246; Sun, 28 Jul 2013 20:34:59 GMT (envelope-from kientzle@FreeBSD.org) Received: from [192.168.2.123] (CiscoE3000 [192.168.1.65]) by kientzle.com with SMTP id p795q3evdkmvb87ad52dmh4wa2; Sun, 28 Jul 2013 20:34:59 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Subject: Re: svn commit: r323836 - in head/devel: . arm-eabi-binutils arm-eabi-binutils/files Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=iso-8859-1 From: Tim Kientzle In-Reply-To: Date: Sun, 28 Jul 2013 13:34:58 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201307281645.r6SGjNAs020031@svn.freebsd.org> To: Jason Helfman X-Mailer: Apple Mail (2.1283) Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 20:35:01 -0000 Thanks for the pointers. I'll try to make these changes. BTW, I note that USES=3Dgmake is not currently documented at = http://www.freebsd.org/doc/en/books/porters-handbook/appendices.html#idp80= 009136 On Jul 28, 2013, at 12:09 PM, Jason Helfman wrote: > On Sun, Jul 28, 2013 at 9:45 AM, Tim Kientzle = wrote: > Author: kientzle (src committer) > Date: Sun Jul 28 16:45:22 2013 > New Revision: 323836 > URL: http://svnweb.freebsd.org/changeset/ports/323836 >=20 > Log: > Add arm-eabi-binutils cross-tools. >=20 > Approved by: db >=20 > Added: head/devel/arm-eabi-binutils/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/devel/arm-eabi-binutils/Makefile Sun Jul 28 16:45:22 = 2013 (r323836) > @@ -0,0 +1,47 @@ > +# $FreeBSD$ > + > +PORTNAME=3D binutils > +PORTVERSION=3D 2.23.2 > +CATEGORIES=3D devel > +MASTER_SITES=3D ${MASTER_SITE_SOURCEWARE} > +MASTER_SITE_SUBDIR=3D binutils/releases > +PKGNAMEPREFIX=3D arm-eabi- > + > +MAINTAINER=3D kientzle@gmail.com > +COMMENT=3D GNU binutils for vanilla ARM cross-development > + > +.if !defined(WITHOUT_NLS) > +USE_GETTEXT=3D yes > +PLIST_SUB+=3D NLS=3D"" > +.else > +CONFIGURE_ARGS+=3D --disable-nls > +PLIST_SUB+=3D NLS=3D"@comment " > +.endif > +USE_BZIP2=3D yes > +USE_GMAKE=3D yes > +USES=3D gettext > +GNU_CONFIGURE=3D yes >=20 >=20 > Is there any particular reason that bsd.port.options.mk wasn't = included here? >=20 > USE_GETTEXT is deprecated, and should be using the USES framework to = bring in the dependency. The only reason this dependency is working is = that it is unconditionally brought in with the USES framework later in = the Makefile. >=20 > To this affect, if NLS is disabled, it brings in gettext dependency. = Can it be disabled? >=20 > USE_GMAKE can be converted, as well, to the USES framework. (USES=3D = gmake) >=20 > .include >=20 > .if ${PORT_OPTIONS:MNLS} > USES+=3D gettext > ... > .endif=20 >=20 > Regardless, as always, thank you so much for your time and effort to = work and get this inclusion into the tree, as I am sure many will = benefit from it. >=20 > -jgh >=20 > --=20 > Jason Helfman | FreeBSD Committer > jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to = Serv