From owner-freebsd-ports-bugs@FreeBSD.ORG Fri May 12 16:40:13 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEF5016AAA2 for ; Fri, 12 May 2006 16:40:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34C3943D46 for ; Fri, 12 May 2006 16:40:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k4CGeDG5059250 for ; Fri, 12 May 2006 16:40:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k4CGeD2X059249; Fri, 12 May 2006 16:40:13 GMT (envelope-from gnats) Resent-Date: Fri, 12 May 2006 16:40:13 GMT Resent-Message-Id: <200605121640.k4CGeD2X059249@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Coleman Kane Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB31716A6A1 for ; Fri, 12 May 2006 16:30:51 +0000 (UTC) (envelope-from cokane@ramen.cokane.org) Received: from smtp1.fuse.net (mail-out1.fuse.net [216.68.8.174]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8CF5843D6D for ; Fri, 12 May 2006 16:30:50 +0000 (GMT) (envelope-from cokane@ramen.cokane.org) Received: from gx4.fuse.net ([72.49.162.239]) by smtp1.fuse.net (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20060512163049.MFRP3018.smtp1.fuse.net@gx4.fuse.net> for ; Fri, 12 May 2006 12:30:49 -0400 Received: from ramen.cokane.org ([72.49.162.239]) by gx4.fuse.net (InterMail vG.1.02.00.02 201-2136-104-102-20041210) with SMTP id <20060512163049.WOJV14894.gx4.fuse.net@ramen.cokane.org> for ; Fri, 12 May 2006 12:30:49 -0400 Received: (qmail 54196 invoked by uid 1001); 13 May 2006 00:32:39 -0000 Message-Id: <20060513003239.54195.qmail@ramen.cokane.org> Date: 13 May 2006 00:32:39 -0000 From: Coleman Kane To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/97178: lang/ruby18 improperly sets PKGNAMESUFFIX X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Coleman Kane List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2006 16:40:17 -0000 >Number: 97178 >Category: ports >Synopsis: lang/ruby18 improperly sets PKGNAMESUFFIX >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri May 12 16:40:12 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Coleman Kane >Release: FreeBSD 7-CURRENT >Organization: FreeBSD developers >Environment: FreeBSD erwin 7.0-CURRENT FreeBSD 7.0-CURRENT #9: Sat Apr 29 20:02:50 EDT 2006 root@erwin:/usr/obj/usr/src/sys/ERWIN amd64 >Description: When building lang/ruby18, there are two tunables: WITH_PTHREADS and WITH_ONIGURUMA When WITH_ONIGURUMA=yes and WITH_PTHREADS=no (or unset), the PKGNAMESUFFIX is set to +oniguruma. When WITH_PTHREADS=yes, regardless of the setting of WITH_ONIGURUMA, the PKGNAMESUFFIX is set to -pthreads. Firstly, the PKGNAMESUFFIX for WITH_PTHREADS should be set to "+pthreads". In addition, the support for oniguruma should not be hidden by WITH_PTHREADS. I think that the following naming is more reflective of the package's tunables: WITHOUT_PTHREADS && WITHOUT_ONIGURUMA --> ruby-1.8.x_y,z WITH_PTHREADS && WITHOUT_ONIGURUMA -----> ruby+pthreads-1.8.x_y,z WITHOUT_PTHREADS && WITH_ONIGURUMA -----> ruby+oniguruma-1.8.x_y,z WITH_PTHREADS && WITH_ONIGURUMA --------> ruby+pthreads+oniguruma-1.8.x_y,z >How-To-Repeat: cd /usr/ports/lang/ruby18 make make clean make WITH_ONIGURUMA=yes make clean make WITH_ONIGURUMA=yes WITH_PTHREADS=yes make clean make WITH_PTHREADS=yes make clean >Fix: Not 100% sure, but I think that where: PKGNAMESUFFIX= +oniguruma ... PKGNAMESUFFIX= -pthreads it should be: PKGNAMESUFFIX+= +oniguruma ... PKGNAMESUFFIX+= +pthreads I do not know if the decision to make the above is a maintainer mistake, or a limitation in the ports/pkg system. >Release-Note: >Audit-Trail: >Unformatted: