Date: Wed, 9 Apr 2014 13:39:57 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-hackers@freebsd.org, Eduardo Morras <emorrasg@yahoo.es> Subject: Re: pipe() resource exhaustion Message-ID: <20140409113957.GB17650@dft-labs.eu> In-Reply-To: <20140409112627.GI21331@kib.kiev.ua> References: <lhu0jv$r6n$1@ger.gmane.org> <ab57e60fcc1c1438fcca500e3c594d35@mail.feld.me> <20140408130206.e75f3bf6c6df28b6e4839e70@yahoo.es> <20140408121222.GB30326@dft-labs.eu> <20140408123827.GW21331@kib.kiev.ua> <20140408130727.GA11363@dft-labs.eu> <20140408132442.GZ21331@kib.kiev.ua> <20140409111654.GA17650@dft-labs.eu> <20140409112627.GI21331@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 09, 2014 at 02:26:27PM +0300, Konstantin Belousov wrote:
> > if (backing) {
> > + /*
> > + * Note that these functions can fail, but we ignore
> > + * the error as it is not fatal and could be provoked
> > + * by users.
> > + */
> It would be benefitial to add some more details on the way to provoke the
> failure. Note in the comment that creating too much pipes would exhaust
> pipe map and we fall back to the buffer pipe creation there, which still
> work correctly, albeit slow.
>
How about:
Note that these functions can fail if pipe map is exhausted (as a result
of too many pipes created), but we ignore the error as it is not fatal
and could be provoked by unprivileged users. The only consequence is worse
performance with given pipe.
--
Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140409113957.GB17650>