Date: Fri, 20 Sep 2002 18:14:48 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Ying-Chieh Liao <ijliao@FreeBSD.org> Cc: Kris Kennaway <kris@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <20020921011447.GA11991@xor.obsecurity.org> In-Reply-To: <20020919181230.GC24699@terry.dragon2.net> References: <200209190016.g8J0Get3023050@freefall.freebsd.org> <20020919181230.GC24699@terry.dragon2.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--h31gzZEtNLTqOjlF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Sep 20, 2002 at 02:12:30AM +0800, Ying-Chieh Liao wrote:
> On Wed, Sep 18, 2002 at 17:16:39 -0700, Kris Kennaway wrote:
> > * [ports/19270] Check whether ${DISTDIR} is writable and fail with a
> > better error message if not (mostly caused by trying to fetch as the
> > wrong user)
>=20
> something wrong here
Please try this patch.
Kris
Index: bsd.port.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.424
diff -u -r1.424 bsd.port.mk
--- bsd.port.mk 19 Sep 2002 00:16:39 -0000 1.424
+++ bsd.port.mk 21 Sep 2002 01:12:24 -0000
@@ -2066,10 +2066,6 @@
=20
.if !target(do-fetch)
do-fetch:
- @if [ ! -w ${DISTDIR} ]; then \
- ${ECHO_MSG} ">> ${DISTDIR} is not writable; cannot fetch."; \
- exit 1; \
- fi
@${MKDIR} ${_DISTDIR}
@(cd ${_DISTDIR}; \
${_MASTER_SITES_ENV} ; \
@@ -2092,6 +2088,10 @@
fi; \
fi; \
${ECHO_MSG} ">> $$file doesn't seem to exist in ${_DISTDIR}."; \
+ if [ ! -w ${DISTDIR} ]; then \
+ ${ECHO_MSG} ">> ${DISTDIR} is not writable by you; cannot fetch."; \
+ exit 1; \
+ fi; \
if [ ! -z "$$select" ] ; then \
__MASTER_SITES_TMP=3D ; \
for group in $$select; do \
--h31gzZEtNLTqOjlF
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)
iD8DBQE9i8gFWry0BWjoQKURAkEYAJ4oVc22rPIjAfdZo4G/gIxZ/tjHwgCdEJ9O
KHnh5ePp6kv5CUEDUXyJMhQ=
=lciT
-----END PGP SIGNATURE-----
--h31gzZEtNLTqOjlF--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020921011447.GA11991>