From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 11 13:00:03 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 922C61065676 for ; Sun, 11 Dec 2011 13:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 46CBB8FC0C for ; Sun, 11 Dec 2011 13:00:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBBD03HZ073612 for ; Sun, 11 Dec 2011 13:00:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBBD03kc073611; Sun, 11 Dec 2011 13:00:03 GMT (envelope-from gnats) Resent-Date: Sun, 11 Dec 2011 13:00:03 GMT Resent-Message-Id: <201112111300.pBBD03kc073611@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Manolis Kiagias Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 052C7106564A for ; Sun, 11 Dec 2011 12:51:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id E96A58FC13 for ; Sun, 11 Dec 2011 12:51:55 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBBCpt22089967 for ; Sun, 11 Dec 2011 12:51:55 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBBCptRH089966; Sun, 11 Dec 2011 12:51:55 GMT (envelope-from nobody) Message-Id: <201112111251.pBBCptRH089966@red.freebsd.org> Date: Sun, 11 Dec 2011 12:51:55 GMT From: Manolis Kiagias To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/163178: [patch] databases/gnats4: edit-pr crashes trying to edit an existing PR X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Dec 2011 13:00:03 -0000 >Number: 163178 >Category: ports >Synopsis: [patch] databases/gnats4: edit-pr crashes trying to edit an existing PR >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 11 13:00:02 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Manolis Kiagias >Release: 9.0-RC3 >Organization: >Environment: FreeBSD joshua.freebsdgr.org 9.0-RC3 FreeBSD 9.0-RC3 #0: Sun Dec 4 08:01:02 UTC 2011 root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: After installing and configuring the databases/gnats4 port, sumbitting a pr via email and trying to edit it with edit-pr, i.e. edit-pr 1: /usr/local/bin/edit-pr: 1: Syntax error: Unterminated quoted string /usr/local/bin/edit-pr: 172: Syntax error: Error in command substitution >How-To-Repeat: Follow the procedure above >Fix: Line 172 is missing a single quote. Apply the following patch Patch attached with submission follows: --- edit-pr.orig 2011-12-11 14:42:46.000000000 +0200 +++ edit-pr 2011-12-11 14:43:01.000000000 +0200 @@ -169,7 +169,7 @@ type="`$QUERY_PR --field-type $field`" case $type in [Ee][Nn][Uu][Mm]) - values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;` + values=`$QUERY_PR --valid-values $field | tr '\n' ' ' | sed 's/ *$//g; s/ / | /g;s/^/[ /;s/$/ ]/;'` valslen=`echo "$values" | wc -c` if [ "$valslen" -gt 160 ] then >Release-Note: >Audit-Trail: >Unformatted: