Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Nov 2019 09:11:22 +0100
From:      Tobias Kortkamp <tobik@freebsd.org>
To:        Jan Beich <jbeich@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r518693 - head/games/aquaria
Message-ID:  <20191130081122.GA25686@urd.tobik.me>
In-Reply-To: <eexp-96i4-wny@FreeBSD.org>
References:  <201911300213.xAU2DJOo019231@repo.freebsd.org> <20191130045840.GA43413@urd.tobik.me> <eexp-96i4-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--5vNYLRcllDrimb99
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 30, 2019 at 08:18:43AM +0100, Jan Beich wrote:
> Tobias Kortkamp <tobik@freebsd.org> writes:
>=20
> > On Sat, Nov 30, 2019 at 02:13:19AM +0000, Jan Beich wrote:
> >
> >> Author: jbeich
> >> Date: Sat Nov 30 02:13:18 2019
> >> New Revision: 518693
> >> URL: https://svnweb.freebsd.org/changeset/ports/518693
> >>=20
> >> Log:
> >>   games/aquaria: partially revert r518662
> >>  =20
> >>   aarch64 and armv7 weren't affected. amd64 was fixed since LLD 7 but
> >>   i386 still fails. Losing LTO (and CFI) support is not worth just for
> >>   consistency with an architecture that may become Tier2 in future.
> >>  =20
> >>   ld: error: cannot preempt symbol: alGetSourcei
> >>   >>> defined in /usr/local/lib/libopenal.so
> >>   >>> referenced by FmodOpenALBridge.cpp
> >>   >>>               CMakeFiles/aquaria.dir/BBGE/FmodOpenALBridge.cpp.o=
:(OggDecoder::decode_loop(OggDecoder*))
> >>  =20
> >>   Pointy hat to:	jbeich (bug 242307 comment 11)
> >
> > What do you think about setting=20
> >
> > LDFLAGS_i386=3D	-Wl,-z,notext
> >
> > here instead (also in openal-soft)?  It unbreaks the build of either
> > one with lld on 12.1 i386.
>=20
> Looks good. I've also tested runtime in 12.1 i386 jail.

Thanks for testing.  It also built fine on 13.0 i386.  I've applied
it to openal-soft in r518709.

--5vNYLRcllDrimb99
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl3iJChfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2Eu8wf+ICUUYCEAsIIeypixUh4AW6lr1WoWLkmVyPYM3IhvDfxENa53uB5TYveY
9ph4lun+uhrmzlE+iZwGu/mHKoT/NZicqXo7jd3481VhDEB/tgMehfy9oanv+/sj
bqtG9koJiV190mgihgYraMP915VQ9oYsEJiSfpZcAvMA+/Q63+oL56wOdkD6wwkZ
K+3adu/klYcgp/vhYB30kOY8W4ztRXNKJX3B/wnBqoAI6JxkKZMwM6mvzt8nrH+D
KzJzg5WxBXKbJiOTxL4HHzblZd5L44rggEL/MEf9C1fynpjcXMjq0H1w5p6s8FvR
CE7z365nk1CBJkTKFJ2Bnm+/tVwd6A==
=p49q
-----END PGP SIGNATURE-----

--5vNYLRcllDrimb99--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191130081122.GA25686>