From owner-freebsd-fs@freebsd.org Mon Oct 17 09:37:59 2016 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87D26C15D9A for ; Mon, 17 Oct 2016 09:37:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 772B5186F for ; Mon, 17 Oct 2016 09:37:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u9H9bwOS072362 for ; Mon, 17 Oct 2016 09:37:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 213507] [msdosfs] [patch]: Prevent occasional directory corruption while extending it to another cluster Date: Mon, 17 Oct 2016 09:37:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 09:37:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213507 --- Comment #8 from Konstantin Belousov --- (In reply to Vladislav Movchan from comment #7) I probably was not clear enough. The problem is that a previous operation left the pages on the vnode page q= ueue behind the directory denode end. The damage is not limited to the situatio= n of extending the directory, it might have other consequences with varying severity. E.g., if the issue also happens for regular files, then extending file might result in the garbage or some previously removed unrelated disk = file content to appear in the extended portion, readable by user. That said, your patch seems to only paper over the real problem. Right thi= ng to do is to track the location where the damage happens. E.g., UFS also had similar problems, where failed file extension (e.g., for lack of free space) was followed by an incomplete cleanup and dandling buffers and pages. --=20 You are receiving this mail because: You are the assignee for the bug.=