From owner-freebsd-ports@FreeBSD.ORG Tue Feb 19 19:07:18 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 77412BF; Tue, 19 Feb 2013 19:07:18 +0000 (UTC) (envelope-from birch@naturalpoint.com) Received: from naturalpoint.com (mail.naturalpoint.com [66.182.52.172]) by mx1.freebsd.org (Postfix) with ESMTP id 51A54FC9; Tue, 19 Feb 2013 19:07:18 +0000 (UTC) Received: from dummy.name; Tue, 19 Feb 2013 11:07:15 -0800 Message-ID: <5123CD39.2070308@naturalpoint.com> Date: Tue, 19 Feb 2013 11:06:33 -0800 From: birch User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Ion-Mihai Tetcu Subject: Re: FreeBSD apcupsd port - patch for APC 9606 SNMP cards References: <500844D0.2040708@naturalpoint.com> <5123B375.30307@naturalpoint.com> <20130219202109.61d6076a@it.tim.tetcu.info> In-Reply-To: <20130219202109.61d6076a@it.tim.tetcu.info> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: ports@FreeBSD.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2013 19:07:18 -0000 Sure, I will do that as well. It looks like not much development has happened since late 2011, so who knows when they will push out their next release. Ion-Mihai Tetcu wrote on 2/19/2013 10:21 AM: > I have no problem integrating this patch, but it should be really > submitted upstream ... > > On Tue, 19 Feb 2013 09:16:37 -0800 > birch wrote: > >> Hello again, >> >> Just did an upgrade to FreeBSD 9.1 and I noticed that the apcupsd >> port still has this crash and requires the patch. It would be >> fantastic if the patch below could be integrated into the port for >> those of us who are using 9606 SNMP cards. >> >> Also adding a CC to ports@FreeBSD.org in case the email address for >> the port maintainer is not being checked. >> >> Many thanks! >> >> birch >> >> >> >> --- >> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp >> +++ >> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp >> @@ -307,6 +307,8 @@ break; >> >> case CI_Overload: >> + if (data.str.len() < 9) >> + break; >> Dmsg1(80, "Got CI_Overload: %c\n", data.str[8]); >> if (data.str[8] == '1') >> ups->set_overload(); >> >> >> >> birch wrote on 7/19/2012 10:33 AM: >>> Hello, >>> >>> The current version of apcupsd in the ports tree for FreeBSD 8.3 no >>> longer works with APC ups's connected via APC 9606 SNMP cards. >>> Would it be possible to get the following patch added to the port, >>> and/or passed upstream? >>> >>> >>> The link below describes the problem and fix in more detail, I have >>> included their patch in this email. I have verified that this patch >>> fixes resolves the issue on FreeBSD 8.3 and allows apcupsd to run >>> without crashing on startup. >>> >>> >>> Thank you, >>> birch >>> >>> "Debian Bug report logs - #655741" >>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655741 >>> >>> >>> Here is the patch as I tested it : >>> >>> --- >>> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp >>> +++ >>> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp >>> @@ -307,6 +307,8 @@ break; >>> >>> case CI_Overload: >>> + if (data.str.len() < 9) >>> + break; >>> Dmsg1(80, "Got CI_Overload: %c\n", data.str[8]); >>> if (data.str[8] == '1') >>> ups->set_overload(); >> > >