From owner-freebsd-current@FreeBSD.ORG Sun Jul 19 17:28:13 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00BFE106564A; Sun, 19 Jul 2009 17:28:13 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-bw0-f208.google.com (mail-bw0-f208.google.com [209.85.218.208]) by mx1.freebsd.org (Postfix) with ESMTP id 49C608FC1A; Sun, 19 Jul 2009 17:28:11 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by bwz4 with SMTP id 4so1410924bwz.43 for ; Sun, 19 Jul 2009 10:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=6P1ZVyNcBSMX8Dmh/2Uc5NQQd6rJYwD53Knh5n7ktG0=; b=ryv1P71/2cghmlNIjXvb4K0vb8+8gkEHurV7wAOnDXU+B2nGU1WcoXClcFfJ/qX+Qk vwbUkdMPt/6wegWZWCetGVT1BDHwliTVq3gdKs084OeIp9wGXnLXWglaU0VrEH2bYn86 QxVMQ/gdL/W8sxfLru9WC1CLJA+F1NJpUV0BA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=vaYxCW0kWdj3IdtT15KFzTv7namzJDKzUpoD9lTzg9nHZ3RaTh7rpfokqGaUdNexe9 79m3o+Hn5e3NRwAbQhgU9ITFKcIQoBTYf4AwGrSwCYuUpjDF6eKtsA7Nlon7lQ6YKVnd PnrgTzrcfqBdlJ7U55ume9fUGgmIH5wlcJmug= MIME-Version: 1.0 Received: by 10.204.51.210 with SMTP id e18mr3407490bkg.69.1248024491072; Sun, 19 Jul 2009 10:28:11 -0700 (PDT) In-Reply-To: <3a142e750907150027t106edef5m767dd0319f83bd63@mail.gmail.com> References: <3a142e750906080809i381c4e6amd93da8a135ab9bd3@mail.gmail.com> <1244477453.7794.2.camel@localhost> <3a142e750906081006v6369051dw75c5077e6032101f@mail.gmail.com> <1244656248.1701.53.camel@localhost> <3a142e750906101108v588e33dfsb0cb81f024c65cfb@mail.gmail.com> <1244658479.1701.56.camel@localhost> <3a142e750906101805re85136cif71eeeda2c641451@mail.gmail.com> <1245323702.1754.0.camel@localhost> <3a142e750907040333o3938c06y6369af6fa6976812@mail.gmail.com> <3a142e750907150027t106edef5m767dd0319f83bd63@mail.gmail.com> Date: Sun, 19 Jul 2009 19:28:10 +0200 Message-ID: <3a142e750907191028u15dfd769o26270d48d15ae664@mail.gmail.com> From: "Paul B. Mahol" To: current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: net@freebsd.org Subject: Re: ndis lor: hal preemption lock X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2009 17:28:13 -0000 On 7/15/09, Paul B. Mahol wrote: > On 7/4/09, Paul B. Mahol wrote: >> On 6/18/09, Coleman Kane wrote: >>> I've committed this one as r194432. >> >> Ah, that one introduced regression. >> Switching ndisX up before creating vap will cause panic. >> Here is fix: >> >> --- /sys/dev/if_ndis/if_ndis.c 2009-06-28 09:15:54.000000000 +0000 >> +++ if_ndis.c 2009-07-04 10:23:41.000000000 +0000 >> @@ -2292,6 +2292,8 @@ >> ifp = sc->ifp; >> ic = ifp->if_l2com; >> vap = TAILQ_FIRST(&ic->ic_vaps); >> + if (vap == NULL) >> + return; >> >> if (!NDIS_INITIALIZED(sc)) { >> DPRINTF(("%s: NDIS not initialized\n", __func__)); > > Bump! > > Please commit. Beep! kern/136895 -- Paul