Date: Sun, 20 Oct 2019 19:08:44 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: Mateusz Piotrowski <0mp@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r514890 - in head/www/quark: . files Message-ID: <20191020170844.m3wyr5mh5dsyjlyt@atuin.in.mat.cc> In-Reply-To: <20191020125556.GA22298@urd.tobik.me> References: <201910201210.x9KCAqYa083092@repo.freebsd.org> <20191020125556.GA22298@urd.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
--qicjie2x7tzjoks3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 20, 2019 at 02:55:56PM +0200, Tobias Kortkamp wrote: > On Sun, Oct 20, 2019 at 12:10:52PM +0000, Mateusz Piotrowski wrote: > > Author: 0mp > > Date: Sun Oct 20 12:10:52 2019 > > New Revision: 514890 > > URL: https://svnweb.freebsd.org/changeset/ports/514890 > >=20 > > Log: > > Update to the latest commit > > =20 > > - Point MASTER_SITES to FreeBSD's servers as we seem to have to host = the > > distfile on our own (I wasn't able to find a way to get a tarball f= rom > > upstream servers). Also, add a "regenerate-distfile" target to ease > > the process of updating the distfile in the future. > > - Update MAKE_ARGS: setting CC there is no longer needed. > > - Remove config.mk patches: it is sufficient for the sake of the port= to > > just remove the include statement from the Makefile. > > =20 > > Changelog: > > https://git.suckless.org/quark/log.html > > =20 > > Reported by: BieHDC > >=20 > > Deleted: > > head/www/quark/files/ > > Modified: > > head/www/quark/Makefile > > head/www/quark/distinfo > >=20 > > Modified: head/www/quark/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/www/quark/Makefile Sun Oct 20 11:38:29 2019 (r514889) > > +++ head/www/quark/Makefile Sun Oct 20 12:10:52 2019 (r514890) > > @@ -1,11 +1,11 @@ > > # $FreeBSD$ > > =20 > > PORTNAME=3D quark > > -DISTVERSION=3D g20180403 > > +DISTVERSION=3D g20190923 > > CATEGORIES=3D www > > -MASTER_SITES=3D https://git.suckless.org/quark/snapshot/ > > +MASTER_SITES=3D https://people.freebsd.org/~0mp/distfiles/ >=20 > This should be LOCAL/0mp instead. You will need to copy the distfile > into your ~/public_distfiles and wait for a bit for that to work. >=20 > > +do-patch: > > + ${REINPLACE_CMD} -e '/^include config.mk$$/d' ${WRKSRC}/Makefile >=20 > There is no reason to overwrite the default do-patch here. It will > just make putting new patches under files/ in the future harder and > breaks stuff like EXTRA_PATCH_TREE etc. Please move this to > post-patch. On top of that, our policy is that patching in the Makefile should ONLY be done when the thing that gets replaced is a variable. Everything else is static and MUST be patched using a patch file. https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html#slow-= patch-automatic-replacements --=20 Mathieu Arnold --qicjie2x7tzjoks3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl2slJxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhGSA/+JlhA+unmxowxydiRMao/cTtos7Lg9R+ZeTDd9gJyxQZ8ZoFIiGYgdjGD wVzSdd3yb1U2ah49M7qZPt2hsb0xh0yxuTAqu97Hp5ElGfTJELo06R1xxfYeFsb7 JsXPW2WNefnehTAAOvX8sLQ5Oq9mx7S+YHiqksyaEcYK5wH93VwcbkRl+NCyfaOj of98kF92mDnntoPi8aCTZQMeqnFBU3+TYjcCt0GS4aulXuMzI+AE6AByaB9Fhh56 wIJOZN0O57tuK8KCLrQFPS8eAibTd8MoSAq5puVLjMyfjCqfXQwJQtSF90W7x8Pt bCZAOoGLs13M3EPv7zmUWURRwCIlOsb7pRtM8526hqbGbyNGGYp5VKNcFP59F6NE JCB2zYPKFlmKgPemcaI++sMO/vvtODyC4d1PReza75WthAlqwJLOlS8wMHC1DOE2 CMutAb8ZgYJ+dpoEPlH4rap/qcYMkEvGhRdoJsNGN9HtHjXbmQkiFC4AnOKfl7bT vnQp6/t5nUIekIDTT3jUvDxZ37hG6vq2pfm0o2wuEMMzrNXZrTdOwUIAOgys63mZ VOKnkldlTzJZuaqnZhYp1f5HyVavLrwdsaGzvB14GBIhvUKtKsND8rxR/eGIcKH1 6NakOiK+vbAEvLTXIPPPRZXghx09qabWSbJ0SzYd0Zg8b0DoNJc= =ubHR -----END PGP SIGNATURE----- --qicjie2x7tzjoks3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191020170844.m3wyr5mh5dsyjlyt>