From owner-svn-src-head@FreeBSD.ORG  Mon Jun 22 15:15:07 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 85B32106567B;
	Mon, 22 Jun 2009 15:15:07 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3])
	by mx1.freebsd.org (Postfix) with ESMTP id 3D39C8FC1D;
	Mon, 22 Jun 2009 15:15:07 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from localhost (amavis.fra.cksoft.de [192.168.74.71])
	by mail.cksoft.de (Postfix) with ESMTP id 2E79741C734;
	Mon, 22 Jun 2009 17:15:06 +0200 (CEST)
X-Virus-Scanned: amavisd-new at cksoft.de
Received: from mail.cksoft.de ([195.88.108.3])
	by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new,
	port 10024)
	with ESMTP id 7OXLXd7f-h0m; Mon, 22 Jun 2009 17:15:05 +0200 (CEST)
Received: by mail.cksoft.de (Postfix, from userid 66)
	id C4D5F41C711; Mon, 22 Jun 2009 17:15:05 +0200 (CEST)
Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net
	[10.111.66.10])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.int.zabbadoz.net (Postfix) with ESMTP id 8C6734448E6;
	Mon, 22 Jun 2009 15:14:42 +0000 (UTC)
Date: Mon, 22 Jun 2009 15:14:42 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
X-X-Sender: bz@maildrop.int.zabbadoz.net
To: src-committers@freebsd.org, svn-src-all@freebsd.org, 
	svn-src-head@freebsd.org
In-Reply-To: <200906221507.n5MF7CIq044459@svn.freebsd.org>
Message-ID: <20090622151017.H22887@maildrop.int.zabbadoz.net>
References: <200906221507.n5MF7CIq044459@svn.freebsd.org>
X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: 
Subject: Re: svn commit: r194629 - head/sys/net
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jun 2009 15:15:08 -0000

On Mon, 22 Jun 2009, Bjoern A. Zeeb wrote:

> Author: bz
> Date: Mon Jun 22 15:07:12 2009
> New Revision: 194629
> URL: http://svn.freebsd.org/changeset/base/194629
>
> Log:
>  Collect all VIMAGE_GLOBALS variables in one place.
>
>  No longer export rt_tables as all lookups go through
>  rt_tables_get_rnh().
>
>  We cannot make rt_tables (and rtstat, rttrash[1]) static as
>  netstat -r (-rs[1]) would stop working on a stripped
>  VIMAGE_GLOBALS kernel.
>
>  Reviewed by:		zec
>  Presumably broken by:	phk 13.5y ago in r12820 [1]

Which seriously leads to the questions:
1) is this because we do not ship stripped kernels?
2) is the kvm_* interface to read them the wrong way?
3) those stats are useless and should be garbage collected entirely?

I only tripped over this because I wanted to do the same to rt_tables
as phk did 13.5 years back to rtstat,rttrash and Marko made me
tripple check things.

-- 
Bjoern A. Zeeb                      The greatest risk is not taking one.