Date: Wed, 14 Apr 2010 11:11:26 +0300 From: Andriy Gapon <avg@icyb.net.ua> To: Maho NAKATA <chat95@mac.com> Cc: ports@FreeBSD.org, srandall52@gmail.com, openoffice@FreeBSD.org Subject: Re: openoffice.org-3.2.0-spadmin Message-ID: <4BC578AE.1000204@icyb.net.ua> In-Reply-To: <20100414.163957.625859878544535218.chat95@mac.com> References: <4BBDF7D1.6070709@icyb.net.ua> <20100414.074742.519459540419532564.chat95@mac.com> <4BC56BEA.6020904@icyb.net.ua> <20100414.163957.625859878544535218.chat95@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 14/04/2010 10:39 Maho NAKATA said the following:
> Hi Andriy
>
> I attached a new patch, just bumped portrevision. Please go ahead and commit.
> Please include "bump PORTREVISION", "approved by maho" in your commit log.
As I said, I can't - I am an src committer, not ports.
> From: Andriy Gapon <avg@icyb.net.ua>
> Subject: Re: openoffice.org-3.2.0-spadmin
> Date: Wed, 14 Apr 2010 10:16:58 +0300
>
>> on 14/04/2010 01:47 Maho NAKATA said the following:
>>> Andriy are you a committer?
>> Different kind - an src one :-)
>>
>>> If you are, you can submit patch to me and I'll approve.
>>> thanks!
>> The patch:
>> --- Makefile.orig 2010-04-14 10:13:44.064102203 +0300
>> +++ Makefile 2010-04-14 10:15:11.615310335 +0300
>> @@ -251,6 +251,7 @@
>> @${REINPLACE_CMD} -e 's#%%PREFIX%%#${PREFIX}#g' \
>> -e 's#%%OOOTAG%%#${OOOTAG}#g' \
>> -e 's#%%OOODIR%%#${OOODIR}#g' \
>> + -e 's#%%OOOVERSION%%#${OOOVERSION}#g' \
>> -e 's#%%INSTALLATION_BASEDIR%%#${INSTALLATION_BASEDIR}#g' \
>> ${WRKDIR}/openoffice.org-wrapper
>> @${INSTALL_SCRIPT} ${WRKDIR}/openoffice.org-wrapper \
>>
>>
>> P.S. sorry for not recognizing you, our openoffice.org maintainer, in the other
>> thread on stable@ :-)
>>
>>> From: Andriy Gapon <avg@icyb.net.ua>
>>> Subject: Re: openoffice.org-3.2.0-spadmin
>>> Date: Thu, 08 Apr 2010 18:35:45 +0300
>>>
>>>> on 08/04/2010 17:34 Steve Randall said the following:
>>>>> On Thu, 08 Apr 2010 14:54:09 +0300
>>>>> Andriy Gapon <avg@icyb.net.ua> wrote:
>>>>>
>>>>>> Not sure if this is an upstream issue or something in editors/openoffice.org-3:
>>>>>> openoffice.org-3.2.0-spadmin is a symlink to openoffice.org-3.2.0 and running it
>>>>>> produces a "new document" startup window.
>>>>>> I believe that it should be a symlink to
>>>>>> ${LOCALBASE}/openoffice.org-3.2.0/openoffice.org3/program/spadmin which is the
>>>>>> actual openoffice.org printer configuration program which, for example, allows to
>>>>>> select which of the printers is to be used as a default one.
>>>>> There's an omission in the port Makefile. The problem is that the
>>>>> wrapper script /usr/local/bin/openoffice.org-3.2.0 contains a
>>>>> %%OOOVERSION%% that does not get replaced (with "3.2.0") prior to
>>>>> installing the file. Just make that change manually and it will work.
>>>> Oh, I see what you say:
>>>> ...
>>>> oopath=/usr/local/openoffice.org-3.2.0/openoffice.org3
>>>> program=`echo $0 | sed -e 's|.*-%%OOOVERSION%%-||'`
>>>> ...
>>>>
>>>> Probably replace command for openoffice.org-wrapper file in post-install target
>>>> needs to grow the following substitution:
>>>> -e 's#%%OOOVERSION%%#${OOOVERSION}#g'
>>>>
>>>> --
>>>> Andriy Gapon
>>>> _______________________________________________
>>>> freebsd-openoffice@freebsd.org mailing list
>>>> http://lists.freebsd.org/mailman/listinfo/freebsd-openoffice
>>>> To unsubscribe, send any mail to "freebsd-openoffice-unsubscribe@freebsd.org"
>>>>
>>
>> --
>> Andriy Gapon
>>
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BC578AE.1000204>