Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Nov 2020 11:41:57 -0800
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Cc:        =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@FreeBSD.org>, Jilles Tjoelker <jilles@FreeBSD.org>
Subject:   Re: svn commit: r554893 - head/Mk/Scripts
Message-ID:  <dac04210-4580-d5ab-49e0-c1b501ea7ee7@FreeBSD.org>
In-Reply-To: <202011111329.0ABDTqUD035770@repo.freebsd.org>
References:  <202011111329.0ABDTqUD035770@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ltzvLlcr6HfXzDPLABGj4CgSnlKs8K3Pf
Content-Type: multipart/mixed; boundary="qLqr4MbtKZ8U8x8f1I4ylRWQLu0AeQS7T";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Cc: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@FreeBSD.org>,
 Jilles Tjoelker <jilles@FreeBSD.org>
Message-ID: <dac04210-4580-d5ab-49e0-c1b501ea7ee7@FreeBSD.org>
Subject: Re: svn commit: r554893 - head/Mk/Scripts
References: <202011111329.0ABDTqUD035770@repo.freebsd.org>
In-Reply-To: <202011111329.0ABDTqUD035770@repo.freebsd.org>

--qLqr4MbtKZ8U8x8f1I4ylRWQLu0AeQS7T
Content-Type: multipart/mixed;
 boundary="------------6A00B6F5274228A37F9A784B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6A00B6F5274228A37F9A784B
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 11/11/2020 5:29 AM, Mathieu Arnold wrote:
> Author: mat
> Date: Wed Nov 11 13:29:52 2020
> New Revision: 554893
> URL: https://svnweb.freebsd.org/changeset/ports/554893
>=20
> Log:
>   Add set pipefail in most framework scripts.
>  =20
>   set pipefail changes the pipeline return status from being the return=

>   status of the last command to the last non 0 exit status of any comma=
nd
>   in the pipeline.  This is needed to make sure all the commands in a
>   pipeline did actually return a non 0 status and not only the last one=
=2E
>  =20
>   PR:		250723
>   Exp-run by:	antoine
>   Reviewed by:	bapt
>   Approved by:	bapt
>   Differential Revision:	https://reviews.freebsd.org/D27007
>=20
> Modified:
>   head/Mk/Scripts/check-desktop-entries.sh   (contents, props changed)
>   head/Mk/Scripts/check-stagedir.sh   (contents, props changed)
>   head/Mk/Scripts/check-vulnerable.sh   (contents, props changed)
>   head/Mk/Scripts/check_leftovers.sh   (contents, props changed)
>   head/Mk/Scripts/checksum.sh   (contents, props changed)
>   head/Mk/Scripts/create-manifest.sh   (contents, props changed)
>   head/Mk/Scripts/depends-list.sh   (contents, props changed)
>   head/Mk/Scripts/desktop-categories.sh   (contents, props changed)
>   head/Mk/Scripts/dialog4ports.sh   (contents, props changed)
>   head/Mk/Scripts/do-depends.sh   (contents, props changed)
>   head/Mk/Scripts/do-fetch.sh   (contents, props changed)
>   head/Mk/Scripts/do-patch.sh   (contents, props changed)
>   head/Mk/Scripts/do-users-groups.sh   (contents, props changed)
>   head/Mk/Scripts/find-lib.sh   (contents, props changed)
>   head/Mk/Scripts/generate-symbols.sh   (contents, props changed)
>   head/Mk/Scripts/install-desktop-entries.sh   (contents, props changed=
)
>   head/Mk/Scripts/makesum.sh   (contents, props changed)
>   head/Mk/Scripts/plist_sub_sed_sort.sh   (contents, props changed)
>   head/Mk/Scripts/ports_env.sh   (contents, props changed)
>   head/Mk/Scripts/qa.sh   (contents, props changed)
>   head/Mk/Scripts/rust-compat11-canary.sh   (contents, props changed)
>   head/Mk/Scripts/smart_makepatch.sh   (contents, props changed)
>=20
> Modified: head/Mk/Scripts/check-desktop-entries.sh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/Mk/Scripts/check-desktop-entries.sh	Wed Nov 11 13:24:31 2020	(=
r554892)
> +++ head/Mk/Scripts/check-desktop-entries.sh	Wed Nov 11 13:29:52 2020	(=
r554893)
> @@ -4,6 +4,7 @@
>  # MAINTAINER: portmgr@FreeBSD.org
> =20
>  set -e
> +set -o pipefail
> =20
>  . "${dp_SCRIPTSDIR}/functions.sh"
> =20
>=20

This can prevent someone from upgrading from an unsupported release. The
workaround is simple enough so I think we should take it rather than
create burdens for people.

    command set -o pipefail 2>/dev/null || :

--=20
Regards,
Bryan Drewery

--------------6A00B6F5274228A37F9A784B--

--qLqr4MbtKZ8U8x8f1I4ylRWQLu0AeQS7T--

--ltzvLlcr6HfXzDPLABGj4CgSnlKs8K3Pf
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl+2yoUFAwAAAAAACgkQNddxu25Gl8+Q
ywgAsnkHhJ1wMdUxFx7UTVSKfog/KH+Ws0oRNO9nR71iJ971407bi63AkH5xgQEtxCquYX5P/S8O
XHlhDycKPy8nxUeoUwpYigobiwBsqwEpPsWYueP3V8EJ0mOTifF7mWh2a080vxSLNX6CqxOehAHo
6VKP9FeCkCxNmx3/2njZId6gVGXusLM+IZIb9shtQynaFxRqAIQe1hOwleiu7J1KCb6ZWZsSBlss
zJfat1/+256FmqVuIX/L2xsri5J7k+R+8bcTPGq61UBtGzQrCM1vaIkkBj4UF+bhYsr8L2+KEXjd
iVH2ZcgvIrMrOFFWVJw5oycyK+tcUWm9dK9u5IIdnQ==
=Xkqb
-----END PGP SIGNATURE-----

--ltzvLlcr6HfXzDPLABGj4CgSnlKs8K3Pf--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dac04210-4580-d5ab-49e0-c1b501ea7ee7>