From owner-svn-ports-head@freebsd.org Thu Nov 19 19:42:03 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 11B30472F6E; Thu, 19 Nov 2020 19:42:03 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CcVSB6kT5z3Kl3; Thu, 19 Nov 2020 19:42:02 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1605814923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ozHWa305G44b0hsDVZ0ExQ8JzrW3Tgr1ayZktGcD4FM=; b=CA6xDExYGCON+jmQoD2G1BF79pAiBVi5AQdIgcnaJZMTiFxyYO79GjT1B9h2YpZqMHM6sZ 2hSy0lVlisaJ1eo1ww83fLEpEW9y7i8UZHLfpQBvDg7a/uWViI4iuJC1akb7YsDfOAyUmB XLZhh3zG+inTaWO8O5ktKqxSWOTJKLnErvO+ccSGy1i6rU7ikkWDwuCutOOOETuTEl/pzy m5QJdY+EisE87KZYcfeRBbMHNbyb72e9psd0rZ1zZvgrlJnAjGc4DUGQDLEhNpsvBP+x3s EnYyaREdDJVNV9b6srQrWXHOeXL1ovbblp449PAzfZ+F6LG/uuyFLKqazhSznA== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 22D21CF61; Thu, 19 Nov 2020 19:42:02 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 454921F2C6; Thu, 19 Nov 2020 19:42:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id xjni3yoRlnsz; Thu, 19 Nov 2020 19:41:57 +0000 (UTC) Subject: Re: svn commit: r554893 - head/Mk/Scripts DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 23E821F2BB To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202011111329.0ABDTqUD035770@repo.freebsd.org> Cc: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= , Jilles Tjoelker From: Bryan Drewery Organization: FreeBSD Message-ID: Date: Thu, 19 Nov 2020 11:41:57 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <202011111329.0ABDTqUD035770@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ltzvLlcr6HfXzDPLABGj4CgSnlKs8K3Pf" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1605814923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ozHWa305G44b0hsDVZ0ExQ8JzrW3Tgr1ayZktGcD4FM=; b=XAju8nZr1l3pFKIXWldXDZtIJ2zn0QiBIXPZPM9ybJhrIDYcHUAybtFWerT3xqrMFtnuI1 885AeahHOrFl+HyuRVFvIwtnWKVlWYC7YVjd1aHdiz6IG6XcLVz0DuGJpNO0e4cedQZE3u Ii9Hq1jrSlxDf7ZjApYlg5HV5Wk9aYQj2I8Q75nwDBSmb7GGN10fAWjV9ZrB21RMMCID3I iZWxRAhcxwbgs/uiuacCX2L1HxQ9gthgEZVqwR7kVVEy2K4F6zu5sr6K1ODhiNhGsDgKgE MyCCHSNSvRLu7dTNTJyUcWi4fFh2F9NqVvxMk9a5Pis25YGC+OuZyT4ttM5YzQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1605814923; a=rsa-sha256; cv=none; b=ggTw/hGS37iN9z1eoIIBJMdQfCNsmhvdO1M9R5UyN15NFzvEGaVi7K0Lx1HdPkmDJk5IRp bzilXeefU+uvkYjsKhMS1TFDHhwrrwYgsIZ0J5fdTIzxUbxIMKk8AC0P/uzzSEALGfc+1K ZsKVOqUFGQulCFMCom82X+Dqu4W9P2wac75LoEC45aZSx/PJgr9BKY7QqU8Kga8TDQCmgB I18GvJvQFyMa2S0DotQlsZy/LJ1ZV2R6BzDpfEBGw6wOmj4hxDn65JWEHd0uDYFIEyXHRC 5hbN/wjmHAdHQKwFB4hlNu3LjrA9E9HdndG8iVUxE6YD1T71U+wTi+dezHSedg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 19:42:03 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ltzvLlcr6HfXzDPLABGj4CgSnlKs8K3Pf Content-Type: multipart/mixed; boundary="qLqr4MbtKZ8U8x8f1I4ylRWQLu0AeQS7T"; protected-headers="v1" From: Bryan Drewery To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= , Jilles Tjoelker Message-ID: Subject: Re: svn commit: r554893 - head/Mk/Scripts References: <202011111329.0ABDTqUD035770@repo.freebsd.org> In-Reply-To: <202011111329.0ABDTqUD035770@repo.freebsd.org> --qLqr4MbtKZ8U8x8f1I4ylRWQLu0AeQS7T Content-Type: multipart/mixed; boundary="------------6A00B6F5274228A37F9A784B" Content-Language: en-US This is a multi-part message in MIME format. --------------6A00B6F5274228A37F9A784B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/11/2020 5:29 AM, Mathieu Arnold wrote: > Author: mat > Date: Wed Nov 11 13:29:52 2020 > New Revision: 554893 > URL: https://svnweb.freebsd.org/changeset/ports/554893 >=20 > Log: > Add set pipefail in most framework scripts. > =20 > set pipefail changes the pipeline return status from being the return= > status of the last command to the last non 0 exit status of any comma= nd > in the pipeline. This is needed to make sure all the commands in a > pipeline did actually return a non 0 status and not only the last one= =2E > =20 > PR: 250723 > Exp-run by: antoine > Reviewed by: bapt > Approved by: bapt > Differential Revision: https://reviews.freebsd.org/D27007 >=20 > Modified: > head/Mk/Scripts/check-desktop-entries.sh (contents, props changed) > head/Mk/Scripts/check-stagedir.sh (contents, props changed) > head/Mk/Scripts/check-vulnerable.sh (contents, props changed) > head/Mk/Scripts/check_leftovers.sh (contents, props changed) > head/Mk/Scripts/checksum.sh (contents, props changed) > head/Mk/Scripts/create-manifest.sh (contents, props changed) > head/Mk/Scripts/depends-list.sh (contents, props changed) > head/Mk/Scripts/desktop-categories.sh (contents, props changed) > head/Mk/Scripts/dialog4ports.sh (contents, props changed) > head/Mk/Scripts/do-depends.sh (contents, props changed) > head/Mk/Scripts/do-fetch.sh (contents, props changed) > head/Mk/Scripts/do-patch.sh (contents, props changed) > head/Mk/Scripts/do-users-groups.sh (contents, props changed) > head/Mk/Scripts/find-lib.sh (contents, props changed) > head/Mk/Scripts/generate-symbols.sh (contents, props changed) > head/Mk/Scripts/install-desktop-entries.sh (contents, props changed= ) > head/Mk/Scripts/makesum.sh (contents, props changed) > head/Mk/Scripts/plist_sub_sed_sort.sh (contents, props changed) > head/Mk/Scripts/ports_env.sh (contents, props changed) > head/Mk/Scripts/qa.sh (contents, props changed) > head/Mk/Scripts/rust-compat11-canary.sh (contents, props changed) > head/Mk/Scripts/smart_makepatch.sh (contents, props changed) >=20 > Modified: head/Mk/Scripts/check-desktop-entries.sh > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Mk/Scripts/check-desktop-entries.sh Wed Nov 11 13:24:31 2020 (= r554892) > +++ head/Mk/Scripts/check-desktop-entries.sh Wed Nov 11 13:29:52 2020 (= r554893) > @@ -4,6 +4,7 @@ > # MAINTAINER: portmgr@FreeBSD.org > =20 > set -e > +set -o pipefail > =20 > . "${dp_SCRIPTSDIR}/functions.sh" > =20 >=20 This can prevent someone from upgrading from an unsupported release. The workaround is simple enough so I think we should take it rather than create burdens for people. command set -o pipefail 2>/dev/null || : --=20 Regards, Bryan Drewery --------------6A00B6F5274228A37F9A784B-- --qLqr4MbtKZ8U8x8f1I4ylRWQLu0AeQS7T-- --ltzvLlcr6HfXzDPLABGj4CgSnlKs8K3Pf Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl+2yoUFAwAAAAAACgkQNddxu25Gl8+Q ywgAsnkHhJ1wMdUxFx7UTVSKfog/KH+Ws0oRNO9nR71iJ971407bi63AkH5xgQEtxCquYX5P/S8O XHlhDycKPy8nxUeoUwpYigobiwBsqwEpPsWYueP3V8EJ0mOTifF7mWh2a080vxSLNX6CqxOehAHo 6VKP9FeCkCxNmx3/2njZId6gVGXusLM+IZIb9shtQynaFxRqAIQe1hOwleiu7J1KCb6ZWZsSBlss zJfat1/+256FmqVuIX/L2xsri5J7k+R+8bcTPGq61UBtGzQrCM1vaIkkBj4UF+bhYsr8L2+KEXjd iVH2ZcgvIrMrOFFWVJw5oycyK+tcUWm9dK9u5IIdnQ== =Xkqb -----END PGP SIGNATURE----- --ltzvLlcr6HfXzDPLABGj4CgSnlKs8K3Pf--