From owner-cvs-src@FreeBSD.ORG Tue Aug 8 12:42:49 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92BE116A4F1; Tue, 8 Aug 2006 12:42:49 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 786CF43D8F; Tue, 8 Aug 2006 12:42:26 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k78CgMCD068793; Tue, 8 Aug 2006 16:42:22 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k78CgLUu068792; Tue, 8 Aug 2006 16:42:21 +0400 (MSD) (envelope-from yar) Date: Tue, 8 Aug 2006 16:42:21 +0400 From: Yar Tikhiy To: Roman Kurakin Message-ID: <20060808124221.GO54416@comp.chem.msu.su> References: <200608061106.k76B6ahO042778@repoman.freebsd.org> <44D5F2C1.7080606@inse.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D5F2C1.7080606@inse.ru> User-Agent: Mutt/1.5.9i Cc: Roman Kurakin , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/examples/drivers make_device_driver.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2006 12:42:49 -0000 On Sun, Aug 06, 2006 at 05:46:41PM +0400, Roman Kurakin wrote: > Example is for developers mostly, so I in doubts about MFC compilation > fixup and this > one commit. I still can remeber that, when the world and I were younger, I used to study FreeBSD examples and sources for any release I had on hand at the moment. There still are plenty of places on the globe where off-line is the normal state of being, so we should provide good reference material for developers on our release CD's, to my mind. This also warrants MFC of fixes to source comments as long as they help to understand the code. Of course, all this is just my private opinion. > Roman Kurakin: > > >rik 2006-08-06 11:06:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > share/examples/drivers make_device_driver.sh > > Log: > > - Added ability to provide (optional) path to the kernel sources > > - Fixed path for ${s}/conf/files.FOO and a note that it should be merged > > into > > corresponding file to be able to compile the kernel > > - Changed kernel configuration example with the driver: it is not > > produced by > > copying Generic but by including it > > - Changed from automatic module building to asking an user if it whants to > > > > Reviewed by: julian@ > > > > Revision Changes Path > > 1.23 +32 -19 src/share/examples/drivers/make_device_driver.sh > > > > -- Yar