From owner-freebsd-bugs@FreeBSD.ORG  Sun Feb  3 05:30:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 8F423A18
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sun,  3 Feb 2013 05:30:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 81B717A9
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sun,  3 Feb 2013 05:30:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r135U1dw013564
 for <freebsd-bugs@freefall.freebsd.org>; Sun, 3 Feb 2013 05:30:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r135U1HP013561;
 Sun, 3 Feb 2013 05:30:01 GMT (envelope-from gnats)
Date: Sun, 3 Feb 2013 05:30:01 GMT
Message-Id: <201302030530.r135U1HP013561@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Giorgos Keramidas <keramida@FreeBSD.org>
Subject: Re: kern/175674: sem_open() should use O_EXLOCK with open() instead
 of a separate flock() call
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Giorgos Keramidas <keramida@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Feb 2013 05:30:01 -0000

The following reply was made to PR kern/175674; it has been noted by GNATS.

From: Giorgos Keramidas <keramida@FreeBSD.org>
To: Jukka Ukkonen <jau@iki.fi>
Cc: freebsd-gnats-submit@FreeBSD.org, jilles@FreeBSD.org,
	davidxu@FreeBSD.org
Subject: Re: kern/175674: sem_open() should use O_EXLOCK with open() instead
 of a separate flock() call
Date: Sun, 3 Feb 2013 06:25:25 +0100

 On 2013-01-29 18:03, Jukka Ukkonen <jau@iki.fi> wrote:
 > >Number:         175674
 > >Category:       kern
 > >Synopsis:       sem_open() should use O_EXLOCK with open() instead of a separate flock() call
 
 > >Environment:
 > FreeBSD sleipnir 9.1-STABLE FreeBSD 9.1-STABLE #2 r246056M: Tue Jan 29 07:33:01 EET 2013     root@sleipnir:/usr/obj/usr/src/sys/Sleipnir  amd64
 > >Description:
 > sem_open() is calling flock() to set a lock on a newly created file descriptor.
 > That is pointless. The open() call a few lines before the flock() could, and
 > in my opinion should, be done with the O_EXLOCK flag set.
 
 It's also a bit safer to obtain the exclusive lock atomically before
 open() returns. Waiting for open() to complete and then calling flock()
 has a race condition.
 
 Jilles and David, do you think this patch looks ok for libc?
 
 > Patch attached with submission follows:
 > 
 > --- lib/libc/gen/sem_new.c.flock	2012-11-09 18:50:05.000000000 +0200
 > +++ lib/libc/gen/sem_new.c	2012-11-09 18:44:59.000000000 +0200
 > @@ -198,11 +198,13 @@
 >  		goto error;
 >  	}
 >  
 > -	fd = _open(path, flags|O_RDWR|O_CLOEXEC, mode);
 > +	fd = _open(path, flags|O_RDWR|O_CLOEXEC|O_EXLOCK, mode);
 >  	if (fd == -1)
 >  		goto error;
 > +#if 0
 >  	if (flock(fd, LOCK_EX) == -1)
 >  		goto error;
 > +#endif
 >  	if (_fstat(fd, &sb)) {
 >  		flock(fd, LOCK_UN);
 >  		goto error;