Date: Sat, 26 Mar 2016 23:21:42 +0100 From: Jan Beich <jbeich@vfemail.net> To: Kurt Jaeger <pi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r411957 - in head/multimedia: . syncplay syncplay/files Message-ID: <twjs-3mo9-wny@vfemail.net> In-Reply-To: <8u14-51v5-wny@vfemail.net> (Jan Beich's message of "Sat, 26 Mar 2016 23:08:14 %2B0100") References: <201603261851.u2QIpL6M096985@repo.freebsd.org> <8u14-51v5-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Jan Beich <jbeich@vfemail.net> writes: > Kurt Jaeger <pi@FreeBSD.org> writes: > >> +.if !empty(PORT_OPTIONS:MCLIENT) && !empty(PORT_OPTIONS:MSERVER) >> +INSTALL_TARGET=3D install >> +.endif >> + >> +.include <bsd.port.mk> > > PORT_OPTIONS is always empty before <bsd.port.options.mk> is included > which this port doesn't attempt. If you want to keep .if conditionals > out try the untested patch below. > > Index: multimedia/syncplay/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- multimedia/syncplay/Makefile (revision 411966) > +++ multimedia/syncplay/Makefile (working copy) > @@ -26,6 +26,7 @@ OPTIONS_MULTI_MODES=3D CLIENT SERVER > VLC_DESC=3D Support for VLC media player >=20=20 > MAKEFILE=3D GNUmakefile > +INSTALL_TARGET=3D # empty Actually, the way INSTALL_TARGET is defined via ?=3D in bsd.port.mk this line is not even needed. OPTIONS_MULTI guarantees either CLIENT or SERVER overrides default value. >=20=20 > GUI_RUN_DEPENDS=3D pyside-py2?>=3D1.1.2:devel/pyside >=20=20 > @@ -34,8 +35,4 @@ VLC_MAKE_ARGS_OFF=3D VLC_SUPPORT=3Dfalse > CLIENT_INSTALL_TARGET=3D install-client > SERVER_INSTALL_TARGET=3D install-server >=20=20 > -.if !empty(PORT_OPTIONS:MCLIENT) && !empty(PORT_OPTIONS:MSERVER) > -INSTALL_TARGET=3D install > -.endif > - > .include <bsd.port.mk> --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJW9wt2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b274IAJ977xjmTdFE/dY+gEXoKkSB 2HNy3eYgj4PXO5BmU5WMhy9nQMEni70mqhwfw21YQ/CRiryJbxO1IodtBFG0KuuP diGaQEoHy0MklylreHGuEFXODlyk9VU3aQbDLuSOWggcOEHNmNZ0u7uSzLV3XqN1 +RY3K4INEqW2BKIqjxaOeNA0syB06GJaiX8gJvanLSGMbBmoU5cZD2xXfDMJ55f0 aHP9ZBh4TOUgSXMH7rctt8XxR88EzIixfdKDL9Z+Ck3FiXtTQmj7nKkKvVsDUATb tEeaAj6FBBPYvFcHFG4+v7eLlvFVs8S7tvtNOITq/+M3Ytov/1J/1NrVeeGgWjE= =KWzS -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?twjs-3mo9-wny>