From owner-freebsd-alpha  Fri Dec  8 12:56: 5 2000
From owner-freebsd-alpha@FreeBSD.ORG  Fri Dec  8 12:56:03 2000
Return-Path: <owner-freebsd-alpha@FreeBSD.ORG>
Delivered-To: freebsd-alpha@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 618)
	id C401D37B404; Fri,  8 Dec 2000 12:56:03 -0800 (PST)
Subject: Re: cvs commit: src/sys/alpha/conf GENERIC
In-Reply-To: <20001208212540.A750@freebie.demon.nl> from Wilko Bulte at "Dec 8, 2000 09:25:40 pm"
To: wkb@freebie.demon.nl (Wilko Bulte)
Date: Fri, 8 Dec 2000 12:56:02 -0800 (PST)
Cc: jhb@FreeBSD.org, alpha@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20001208205603.C401D37B404@hub.freebsd.org>
From: wpaul@FreeBSD.ORG (Bill Paul)
Sender: owner-freebsd-alpha@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

While looking over the code, something jumped out at me. In
epic_common_attach(), we have this:

        i = sizeof(struct epic_frag_list)*TX_RING_SIZE +
            sizeof(struct epic_rx_desc)*RX_RING_SIZE + 
            sizeof(struct epic_tx_desc)*TX_RING_SIZE + PAGE_SIZE,
        sc->pool = (epic_softc_t *) malloc( i, M_DEVBUF, M_NOWAIT);

There are two C statements here: one to assign a value to i, and another
to malloc() i bytes worth of space and leave the address of the buffer
in sc->pool. Except the first statement doesn't end with a semicolon.

How is this not a syntax error?

-Bill


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message