Date: Wed, 9 Jun 2010 15:07:53 -0700 From: Ben Fiedler <bfiedler@asu.edu> To: Garrett Cooper <gcooper@freebsd.org> Cc: Benjamin Fiedler <bfiedler@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 179341 for review Message-ID: <AANLkTilDlp_gKVOu7vMi8UxF52BMN39s2UIsFztkkjTV@mail.gmail.com> In-Reply-To: <AANLkTin9N4E0L1rqpEzMR79cF5EuFQowiTSt0pKZARHn@mail.gmail.com> References: <201006090217.o592H6M7095917@repoman.freebsd.org> <AANLkTin9N4E0L1rqpEzMR79cF5EuFQowiTSt0pKZARHn@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > > > > +DEBUG = -g > > PROG= diff > > SRCS= diff.c diffdir.c diffreg.c > > -CFLAGS+= -std=c99 -Wall -pedantic > > +CFLAGS+= -std=c99 -Wall -pedantic $(DEBUG) > > That's what the DEBUG_FLAG var does? > Ah, so it does. Thanks. > > > > > > -int aflag, bflag, dflag, iflag, lflag, Nflag, Pflag, pflag, rflag; > > +int aflag, Bflag, bflag, dflag, iflag, lflag, Nflag, Pflag, pflag, > rflag; > > This could make merging patches entertaining if you add or remove a > variable; it probably would be easier if each variable was per-line. > > A decent point. I suppose I can do them all on newlines for now.. > > > int sflag, tflag, Tflag, wflag; > > int format, context, status; > > ... > > > + strcmp(dent1->d_name, dent2->d_name) ; > > This is kind of hard to read... can this be split up into if-based > branch statements? > It easily could be split; I was just trying to adhere to the already-present style. -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTilDlp_gKVOu7vMi8UxF52BMN39s2UIsFztkkjTV>