From owner-freebsd-rc@freebsd.org  Wed Aug 30 13:02:51 2017
Return-Path: <owner-freebsd-rc@freebsd.org>
Delivered-To: freebsd-rc@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA37AE01859
 for <freebsd-rc@mailman.ysv.freebsd.org>; Wed, 30 Aug 2017 13:02:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C824C6C3FE
 for <freebsd-rc@FreeBSD.org>; Wed, 30 Aug 2017 13:02:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7UD2pq8047611
 for <freebsd-rc@FreeBSD.org>; Wed, 30 Aug 2017 13:02:51 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-rc@FreeBSD.org
Subject: [Bug 199127] rc.d/ntpd: user-set ntpd_flags stomps over rc-defined
 ones (pidfile, driftfile)
Date: Wed, 30 Aug 2017 13:02:50 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: conf
X-Bugzilla-Version: 9.2-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: crees@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc attachments.created
Message-ID: <bug-199127-4805-GQFpUdoNZ9@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-199127-4805@https.bugs.freebsd.org/bugzilla/>
References: <bug-199127-4805@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc/>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Aug 2017 13:02:52 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D199127

Chris Rees <crees@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crees@FreeBSD.org

--- Comment #2 from Chris Rees <crees@FreeBSD.org> ---
Created attachment 185920
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185920&action=
=3Dedit
Use command_args not rc_flags to avoid rc.conf messing up configuration

I've come across this bug too, but only realised after seeing this one :)

On my machine the pidfile doesn't appear because I've overridden ntpd_flags=
 in
rc.conf.

The correct use is to have command_args for non-configurable stuff, not (ab=
)use
${name}_flags and hope no-one changes them!

Please would someone approve me to commit this?

Cheers!

Chris

--=20
You are receiving this mail because:
You are the assignee for the bug.=