From owner-cvs-all@FreeBSD.ORG  Mon Aug  4 14:08:06 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 918F61065757;
	Mon,  4 Aug 2008 14:08:06 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id AFC078FC19;
	Mon,  4 Aug 2008 14:08:05 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (zion.baldwin.cx
	[IPv6:2001:470:1f11:75:2a0:d2ff:fe18:8b38]) (authenticated bits=0)
	by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m74E7krv080837;
	Mon, 4 Aug 2008 10:07:59 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Sam Leffler <sam@freebsd.org>
Date: Mon, 4 Aug 2008 09:26:25 -0400
User-Agent: KMail/1.9.7
References: <200808021742.m72HgdBX031929@svn.freebsd.org>
In-Reply-To: <200808021742.m72HgdBX031929@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808040926.25626.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx
	[IPv6:2001:470:1f11:75::1]); Mon, 04 Aug 2008 10:07:59 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.93.1/7935/Mon Aug 4 08:58:49 2008 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: svn commit: r181191 - in head: share/man/man9 sys/kern sys/sys
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2008 14:08:06 -0000

On Saturday 02 August 2008 01:42:39 pm Sam Leffler wrote:
> Author: sam
> Date: Sat Aug  2 17:42:38 2008
> New Revision: 181191
> URL: http://svn.freebsd.org/changeset/base/181191
>
> Log:
>   add callout_schedule; besides being useful it also improves
>   compatibility with other systems
>
>   Reviewed by:	ed, battlez

I think it probably warrants a KASSERT() that c_func isn't NULL to catch the 
case of someone doing:

	callout_init(...);

	callout_schedule(...);

I'd almost prefer that we add (func, arg) pointers to the init routines so you 
do this:

	callout_init_mtx(&sc->timer, &sc->lock, timer_func, sc);

	...

	callout_schedule(&sc->timer, hz);

Right now you have to make sure you do at least one 'callout_reset' before you 
do a 'callout_schedule' which seems bug-prone.

-- 
John Baldwin