Date: Sun, 29 Dec 2002 21:17:05 -0800 From: David Schultz <dschultz@uclink.Berkeley.EDU> To: Kris Kennaway <kris@citusc.usc.edu> Cc: Mike Barcroft <mike@sparc64.style9.org>, current@FreeBSD.ORG, sparc64@FreeBSD.ORG Subject: Re: sparc64 tinderbox failure Message-ID: <20021230051705.GA5307@HAL9000.homeunix.com> In-Reply-To: <20021229202731.B22633@citusc.usc.edu> References: <200212300321.gBU3LMWB011861@bowie.private> <20021229202731.B22633@citusc.usc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake Kris Kennaway <kris@citusc.usc.edu>: > On Mon, Dec 30, 2002 at 03:21:22AM +0000, Mike Barcroft wrote: > > > ===> sbin/swapon > > cc1: warnings being treated as errors > > /tinderbox/sparc64/src/sbin/swapon/swapon.c: In function `swaplist': > > /tinderbox/sparc64/src/sbin/swapon/swapon.c:246: warning: field width is not type int (arg 3) > > Can someone please just fix this (by backing out the offending commit, > if necessary)? Eek, given a 64-bit size_t, the present code leaves 32 bits of it uninitialized in the usual case. The following patch ought to fix the problem; I can't make sure right now because I'm out of town. Index: swapon.c =================================================================== RCS file: /home/ncvs/src/sbin/swapon/swapon.c,v retrieving revision 1.14 diff -u -r1.14 swapon.c --- swapon.c 2002/12/28 23:39:47 1.14 +++ swapon.c 2002/12/30 05:15:54 @@ -211,7 +211,7 @@ size_t mibsize, size; struct xswdev xsw; int mib[16], n, pagesize; - size_t hlen; + int hlen; long blocksize; long long total = 0; long long used = 0; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021230051705.GA5307>