Date: Fri, 23 Aug 2019 15:59:29 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r508657 - head/biology/gperiodic Message-ID: <20190823135928.eyy6ebotbhtqrcb4@ivaldir.net> In-Reply-To: <201908111729.x7BHTA28047338@repo.freebsd.org> References: <201908111729.x7BHTA28047338@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--2pdnptuzfsnya2rm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 11, 2019 at 05:29:10PM +0000, Kurt Jaeger wrote: > Author: pi > Date: Sun Aug 11 17:29:10 2019 > New Revision: 508657 > URL: https://svnweb.freebsd.org/changeset/ports/508657 >=20 > Log: > biology/gperiodic: upgrade 2.0.10 -> 3.0.3 > =20 > - new mastersite I am not sure this has been really reviewed before it has been committed, s= ee the comments inline below. Bapt > =20 > PR: 239642 > Submitted by: Walter Schwarzenfeld <w.schwarzenfeld@utanet.at> > Relnotes: https://sourceforge.net/p/gperiodic/code/HEAD/tree/branches/3= =2E0.3/ChangeLog >=20 > Modified: > head/biology/gperiodic/Makefile > head/biology/gperiodic/distinfo > head/biology/gperiodic/pkg-plist >=20 > Modified: head/biology/gperiodic/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/biology/gperiodic/Makefile Sun Aug 11 17:10:07 2019 (r508656) > +++ head/biology/gperiodic/Makefile Sun Aug 11 17:29:10 2019 (r508657) > @@ -3,10 +3,9 @@ > # $MCom: ports/biology/gperiodic/Makefile,v 1.1 2006/09/29 23:42:13 a= hze Exp $ > =20 > PORTNAME=3D gperiodic > -PORTVERSION=3D 2.0.10 > -PORTREVISION=3D 8 > +PORTVERSION=3D 3.0.3 > CATEGORIES=3D biology > -MASTER_SITES=3D http://www.frantz.fi/software/ > +MASTER_SITES=3D https://sourceforge.net/projects/gperiodic/files/ > =20 > MAINTAINER=3D ports@FreeBSD.org > COMMENT=3D Displays a periodic table of the elements > @@ -14,15 +13,13 @@ COMMENT=3D Displays a periodic table of the elements > LICENSE=3D GPLv2+ > LICENSE_FILE=3D ${WRKSRC}/gpl.txt > =20 > -BROKEN=3D unfetchable > - > -USE_GNOME=3D gtk20 > USES=3D pkgconfig > +USE_GNOME=3D gtk20 > =20 > -LANGS=3D da fr gl it pl ru sv tr > - > PORTDOCS=3D AUTHORS ChangeLog README > =20 > +LANGS=3D be cs da de es fi fr gl is it ms pl pt ru sv tr uk zh_CN > + > OPTIONS_DEFINE=3D DOCS NLS > OPTIONS_SUB=3D yes > =20 > @@ -39,9 +36,7 @@ do-build-NLS-on: > =20 > do-install: > ${INSTALL_PROGRAM} ${WRKSRC}/gperiodic ${STAGEDIR}${PREFIX}/bin > - ${INSTALL_DATA} ${WRKSRC}/gperiodic.desktop \ > - ${STAGEDIR}${PREFIX}/share/applications > - (cd ${WRKSRC} && ${INSTALL_DATA} gperiodic.png gperiodic-crystal.png \ > + (cd ${WRKSRC}/icons && ${INSTALL_DATA} gperiodic-crystal.png gperiodic.= png \ > ${STAGEDIR}${PREFIX}/share/pixmaps) > =20 > do-install-NLS-on: > @@ -50,6 +45,13 @@ do-install-NLS-on: > ${INSTALL_DATA} ${WRKSRC}/po/${lang}.mo \ > ${STAGEDIR}${PREFIX}/share/locale/${lang}/LC_MESSAGES/${PORTNAME}.mo > .endfor > + ${MKDIR} ${STAGEDIR}${PREFIX}/share/locale/gperiodic > + ${INSTALL_DATA} ${WRKSRC}/table_data.h \ > + ${STAGEDIR}${PREFIX}/share/locale/gperiodic > + ${INSTALL_DATA} ${WRKSRC}/po/gperiodic.pot \ > + ${STAGEDIR}${PREFIX}/share/locale/gperiodic > + ${INSTALL_DATA} ${WRKSRC}/po/README \ > + ${STAGEDIR}/${PREFIX}/share/locale/gperiodic=09 Those new lines are installing things in the locale directory which does not belong to the share/locale directory! > =20 > do-install-DOCS-on: > @${MKDIR} ${STAGEDIR}${DOCSDIR} >=20 > Modified: head/biology/gperiodic/distinfo > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/biology/gperiodic/distinfo Sun Aug 11 17:10:07 2019 (r508656) > +++ head/biology/gperiodic/distinfo Sun Aug 11 17:29:10 2019 (r508657) > @@ -1,2 +1,3 @@ > -SHA256 (gperiodic-2.0.10.tar.gz) =3D 78d72870c51c39e4a35c804c05b8ef5e39f= 88d42eced52b2934e21d74fb8d096 > -SIZE (gperiodic-2.0.10.tar.gz) =3D 131213 > +TIMESTAMP =3D 1564926393 > +SHA256 (gperiodic-3.0.3.tar.gz) =3D 5e70128f61a311bd6b4ad129bd726ccc0e37= 31573cb0050201293e2a5389b29a > +SIZE (gperiodic-3.0.3.tar.gz) =3D 451559 >=20 > Modified: head/biology/gperiodic/pkg-plist > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/biology/gperiodic/pkg-plist Sun Aug 11 17:10:07 2019 (r508656) > +++ head/biology/gperiodic/pkg-plist Sun Aug 11 17:29:10 2019 (r508657) > @@ -1,12 +1,25 @@ > +@postexec chmod -R 770 /usr/local/share/locale/gperiodic ^^ This should never ever be done, why do you think it is necessary to do it h= ere? > bin/gperiodic > -share/applications/gperiodic.desktop > -%%NLS%%share/locale/da/LC_MESSAGES/gperiodic.mo > -%%NLS%%share/locale/fr/LC_MESSAGES/gperiodic.mo > -%%NLS%%share/locale/gl/LC_MESSAGES/gperiodic.mo > -%%NLS%%share/locale/it/LC_MESSAGES/gperiodic.mo > -%%NLS%%share/locale/pl/LC_MESSAGES/gperiodic.mo > -%%NLS%%share/locale/ru/LC_MESSAGES/gperiodic.mo > -%%NLS%%share/locale/sv/LC_MESSAGES/gperiodic.mo > -%%NLS%%share/locale/tr/LC_MESSAGES/gperiodic.mo > -share/pixmaps/gperiodic.png > +share/locale/be/LC_MESSAGES/gperiodic.mo > +share/locale/cs/LC_MESSAGES/gperiodic.mo > +share/locale/da/LC_MESSAGES/gperiodic.mo > +share/locale/de/LC_MESSAGES/gperiodic.mo > +share/locale/es/LC_MESSAGES/gperiodic.mo > +share/locale/fi/LC_MESSAGES/gperiodic.mo > +share/locale/fr/LC_MESSAGES/gperiodic.mo > +share/locale/gl/LC_MESSAGES/gperiodic.mo > +share/locale/gperiodic/README > +share/locale/gperiodic/gperiodic.pot > +share/locale/gperiodic/table_data.h > +share/locale/is/LC_MESSAGES/gperiodic.mo > +share/locale/it/LC_MESSAGES/gperiodic.mo > +share/locale/ms/LC_MESSAGES/gperiodic.mo > +share/locale/pl/LC_MESSAGES/gperiodic.mo > +share/locale/pt/LC_MESSAGES/gperiodic.mo > +share/locale/ru/LC_MESSAGES/gperiodic.mo > +share/locale/sv/LC_MESSAGES/gperiodic.mo > +share/locale/tr/LC_MESSAGES/gperiodic.mo > +share/locale/uk/LC_MESSAGES/gperiodic.mo > +share/locale/zh_CN/LC_MESSAGES/gperiodic.mo The %%NLS has been removed, meaning the port is now broken with the NLS opt= ion set to off. > share/pixmaps/gperiodic-crystal.png > +share/pixmaps/gperiodic.png >=20 --2pdnptuzfsnya2rm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl1f8T4ACgkQY4mL3PG3 PlolRA//YJ5NM3KYaUz5mbf1uq6UiwXjU2SwXEqgZOqahL2RxfWtK+d4pIv+6abF zNFWrZlpNfilC7KMxCRJCfNQAThF8tISXojeY6cry1b9AUMN5uqRgoGf50WC0qhL 1PJ16GgtPUmnJoaKmCXwI1x0ghWCULuTkK6tBNdeYpX+WFBISiYn1JtOiT2tCJjw sXI3Y136kgSlTQKb8hxJUbijtf0XNf5W/myJrqL1uxCs3OvF6LUj7fAw99CoNou7 6L00AiguIHGsZ/2A57mILYDCXxxAGOENjqxCngdTwN8tYYiI6lalLgUX2F7LR/ZM e/pb+py1qydm5rquMBLO2RBd3nRolZRungc0t6HcjbGLPjJsFzC/9fE2NeyzVSaL aGoVDE+5YtSE5V43t0XoMnOoRcbktAeQD2AXQy/V5hnCytxsjOjMrGgws4otVARv rZR05vO9xfuAVowcGjj8Upx+0t6d1btSlRs/nQw8PGwu7VHnyZ7OE57LA2MzpW9t /wKSna4tSUGMSYeOKK6mhprUK4fCx84JrDhHYHUSv92rKfvWICB/6SYLrj9pq9aa LlBwIUuayyPHjBYkYLFWXhm27CqQZEp/9OZb8jRDK0YcSr1Fl+ex+L70h8wa6pQV WX74y4yPcS4gAqm/6yr1MLR0+Qk9mCcgGoEKLaWTYEP6t5FP2io= =qyhp -----END PGP SIGNATURE----- --2pdnptuzfsnya2rm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190823135928.eyy6ebotbhtqrcb4>