Date: Wed, 13 Mar 2013 23:08:31 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Dirk Engling <erdgeist@erdgeist.org> Cc: freebsd-current@freebsd.org Subject: Re: pidfile_open incorrectly returns EAGAIN when pidfile is locked Message-ID: <20130313220831.GF1372@garage.freebsd.pl> In-Reply-To: <alpine.BSF.2.00.1303132256540.67262@erdgeist.org> References: <513F8D20.2050707@erdgeist.org> <201303131118.36811.jhb@freebsd.org> <20130313212750.GC1372@garage.freebsd.pl> <alpine.BSF.2.00.1303132256540.67262@erdgeist.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--5CUMAwwhRxlRszMD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2013 at 10:59:17PM +0100, Dirk Engling wrote: >=20 > On Wed, 13 Mar 2013, Pawel Jakub Dawidek wrote: >=20 > > How about this patch? > > > > http://people.freebsd.org/~pjd/patches/pidfile.c.patch >=20 > If you move the lines >=20 > + if (errno =3D=3D 0 || errno =3D=3D EAGAIN) > + errno =3D EEXIST; >=20 > out of the else branch, you can get rid of the if branch, guard the else= =20 > branch by a >=20 > + if (pidptr) { >=20 > and let the if (errno =3D=3D 0 || errno =3D=3D EAGAIN) fix the errno I think I considered something similar at first, but the change I proposed was optimal, IMHO at the cost of producing pretty large diff, because of indentation change. But to be sure, can you send a patch of your proposed change? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --5CUMAwwhRxlRszMD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFA+N8ACgkQForvXbEpPzSwOwCgucrbfgLbYpEndajoK84jzNel TbYAoIlOUughbXL1fwTXkqucJtyv4pNk =Nnvl -----END PGP SIGNATURE----- --5CUMAwwhRxlRszMD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130313220831.GF1372>