From owner-freebsd-standards Fri Dec 14 0:34:34 2001 Delivered-To: freebsd-standards@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 522FE37B416 for ; Fri, 14 Dec 2001 00:34:27 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fBE8Y5k40260; Fri, 14 Dec 2001 10:34:05 +0200 (EET) (envelope-from ru) Date: Fri, 14 Dec 2001 10:34:05 +0200 From: Ruslan Ermilov To: Mark Murray Cc: standards@FreeBSD.ORG Subject: Re: Wrong type for gid in include/gid.h? Message-ID: <20011214103405.D35094@sunbay.com> References: <200112131912.fBDJCRU79566@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112131912.fBDJCRU79566@grimreaper.grondar.org> User-Agent: Mutt/1.3.23i Sender: owner-freebsd-standards@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Dec 13, 2001 at 07:12:27PM +0000, Mark Murray wrote: > Hi > > This patch fixes a few warnings in usr.bin and has worked > fine for me for N make worlds and about a month of runtime. > > Any objections to me committing this? > > M > Index: grp.h > =================================================================== > RCS file: /home/ncvs/src/include/grp.h,v > retrieving revision 1.3 > diff -u -d -r1.3 grp.h > --- grp.h 7 May 1997 19:59:59 -0000 1.3 > +++ grp.h 7 Dec 2001 20:48:47 -0000 > @@ -48,7 +48,7 @@ > struct group { > char *gr_name; /* group name */ > char *gr_passwd; /* group password */ > - int gr_gid; /* group id */ > + gid_t gr_gid; /* group id */ > char **gr_mem; /* group members */ > }; > If you also going to fix initgroups(3) and friends, I'm all for that. NetBSD had this for years. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message