From owner-freebsd-current@FreeBSD.ORG Sat Aug 28 01:01:28 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F1BC16A4CE; Sat, 28 Aug 2004 01:01:28 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9DE843D48; Sat, 28 Aug 2004 01:01:27 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i7S10Aqw019804; Fri, 27 Aug 2004 19:00:15 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 27 Aug 2004 19:00:10 -0600 (MDT) Message-Id: <20040827.190010.133432154.imp@bsdimp.com> To: gurney_j@resnet.uoregon.edu From: "M. Warner Losh" In-Reply-To: <20040819180840.GV99980@funkthat.com> References: <4124E1DA.B5341C04@freebsd.org> <1092938019.79038.4.camel@server.mcneil.com> <20040819180840.GV99980@funkthat.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: freebsd-current@freebsd.org cc: andre@freebsd.org cc: sean@mcneil.com Subject: Re: kernel module options X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Aug 2004 01:01:28 -0000 In message: <20040819180840.GV99980@funkthat.com> John-Mark Gurney writes: : Sean McNeil wrote this message on Thu, Aug 19, 2004 at 10:53 -0700: : > On Thu, 2004-08-19 at 10:22, Andre Oppermann wrote: : > > IPDIVERT wasn't compiled into the module before. It's surrounded by : > > #if !defined(KLD_MODULE). However if the kernel was compiled with option : > > IPDIVERT but w/o IPFIREWALL is was working anyway. : > : > Has this changed? From what I saw yesterday no option in my config file : > could possibly effect the compilation of the ipfw2 module. The only way : > I could see doing it was to modify the Makefile for the module. yuk. : > : > I would like to see a general mechanism supported to turn on various : > options within a module build. Would it be possible to fix module : > building to honor options from the config? : : I had a set of changes a while back that would link all of the opt_*.h : files in the various module's dirs back to the ones in the main kernel : compile assuming that there wasn't a specific rule in the Makefile to : build that file. I.e. 99% of the opt_*.h rules could be eliminated. We already do this when building the modules as part of the kernel. However, you can't eliminat ethe opt_*.h rules in the sys/modules/*/Makefile because you still have to build in the building in the world case. : This solution was decided to be inadaquate, and was not accepted, but : I again propose it. It quick and easy. If I understand it correctly, it is still inadequate. Many of the opt_*.h rules in the makefiles have been elminated by having the default rule for them. Warner