Date: Fri, 2 Dec 2011 19:05:45 +0530 From: "Jayachandran C." <jchandra@freebsd.org> To: freebsd-sparc64@freebsd.org Cc: marius@freebsd.org Subject: [PATCH] fix OF_finddevice return value checks on sparc64 Message-ID: <CA%2B7sy7B41x0izHhgHLGDFutSUr3y0dCYPnj3tnVfcYfeprhpLQ@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--f46d04427272caaff004b31c0b65 Content-Type: text/plain; charset=ISO-8859-1 While going thru the OF_finddevice usage in kernel (to fix up the FDT interface) I noticed that a few calls made to OF_finddevice in sparc64 does not check the return value correctly. The error return is -1 not 0, and since the value is unsigned, checking it for '< 0' does not work either. The attached patch fixes this. Regards, JC. --f46d04427272caaff004b31c0b65 Content-Type: text/x-patch; charset=US-ASCII; name="sparc64-of-finddev-fixes.patch" Content-Disposition: attachment; filename="sparc64-of-finddev-fixes.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gvp8ltsr0 SW5kZXg6IHN5cy9zcGFyYzY0L3NwYXJjNjQvdm1fbWFjaGRlcC5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5 cy9zcGFyYzY0L3NwYXJjNjQvdm1fbWFjaGRlcC5jCShyZXZpc2lvbiAyMjgxOTcpCisrKyBzeXMv c3BhcmM2NC9zcGFyYzY0L3ZtX21hY2hkZXAuYwkod29ya2luZyBjb3B5KQpAQCAtMzY4LDcgKzM2 OCw3IEBACiAJCShjZWxsX3QpYnNwZWMKIAl9OwogCi0JaWYgKChjaG9zZW4gPSBPRl9maW5kZGV2 aWNlKCIvY2hvc2VuIikpICE9IDApIHsKKwlpZiAoKGNob3NlbiA9IE9GX2ZpbmRkZXZpY2UoIi9j aG9zZW4iKSkgIT0gLTEpIHsKIAkJaWYgKE9GX2dldHByb3AoY2hvc2VuLCAiYm9vdHBhdGgiLCBi c3BlYywgc2l6ZW9mKGJzcGVjKSkgPT0gLTEpCiAJCQlic3BlY1swXSA9ICdcMCc7CiAJCWJzcGVj W3NpemVvZihic3BlYykgLSAxXSA9ICdcMCc7CkluZGV4OiBzeXMvc3BhcmM2NC9zcGFyYzY0L29m d19tYWNoZGVwLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL3NwYXJjNjQvc3BhcmM2NC9vZndfbWFjaGRl cC5jCShyZXZpc2lvbiAyMjgxOTcpCisrKyBzeXMvc3BhcmM2NC9zcGFyYzY0L29md19tYWNoZGVw LmMJKHdvcmtpbmcgY29weSkKQEAgLTUyLDcgKzUyLDcgQEAKIAlwaGFuZGxlX3Qgbm9kZTsKIAlz dHJ1Y3QgaWRwcm9tIGlkcDsKIAotCWlmICgobm9kZSA9IE9GX2ZpbmRkZXZpY2UoIi9vcHRpb25z IikpID4gMCAmJgorCWlmICgobm9kZSA9IE9GX2ZpbmRkZXZpY2UoIi9vcHRpb25zIikpICE9IC0x ICYmCiAJICAgIE9GX2dldHByb3Aobm9kZSwgImxvY2FsLW1hYy1hZGRyZXNzPyIsIGJ1Ziwgc2l6 ZW9mKGJ1ZikpID4gMCkgewogCQlidWZbc2l6ZW9mKGJ1ZikgLSAxXSA9ICdcMCc7CiAJCWlmIChz dHJjbXAoYnVmLCAidHJ1ZSIpID09IDAgJiYK --f46d04427272caaff004b31c0b65--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B7sy7B41x0izHhgHLGDFutSUr3y0dCYPnj3tnVfcYfeprhpLQ>