From owner-freebsd-ports@FreeBSD.ORG  Wed Jul 13 11:59:02 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 69744106564A;
	Wed, 13 Jul 2011 11:59:02 +0000 (UTC) (envelope-from pav@FreeBSD.org)
Received: from sup.oook.cz (sup.oook.cz [94.23.0.135])
	by mx1.freebsd.org (Postfix) with ESMTP id EF37D8FC1B;
	Wed, 13 Jul 2011 11:59:01 +0000 (UTC)
Received: from pav.hide.vol.cz ([212.24.129.198]) (authenticated bits=0)
	by sup.oook.cz (8.14.4/8.14.4) with ESMTP id p6DBdvXe077097
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
	Wed, 13 Jul 2011 13:40:00 +0200 (CEST)
	(envelope-from pav@FreeBSD.org)
Message-ID: <4E1D8408.1080609@FreeBSD.org>
Date: Wed, 13 Jul 2011 13:39:52 +0200
From: Pav Lucistnik <pav@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.2.15) Gecko/20110414 Thunderbird/3.1.9
MIME-Version: 1.0
To: Jung-uk Kim <jkim@FreeBSD.org>
References: <201107121826.00020.jkim@FreeBSD.org>
In-Reply-To: <201107121826.00020.jkim@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 94.23.0.135
X-Milter: Spamilter (Reciever: sup.oook.cz; Sender-ip: 212.24.129.198;
	Sender-helo: pav.hide.vol.cz; )
Cc: Stephen Montgomery-Smith <stephen@FreeBSD.org>, freebsd-ports@FreeBSD.org
Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2011 11:59:02 -0000

On 2011/07/13 00:25, Jung-uk Kim wrote:
> After I updated x11-wm/compiz, GNOME was not able to start the window
> manager.  Basically, it complained that compiz-manager was not found.
> Then, I realized compiz-manager.desktop was automagically replaced by
> compizmanager.desktop.  Now I tracked it down to this commit:
>
> Sat Nov 27 17:42:46 2010 UTC (7 months, 2 weeks ago) by pav
>
> - DESKTOP_ENTRIES: commandline is used to name installed .desktop
> file, this can lead to files containing whitespace and funny
> characters; thus strip all non-alphanumeric characters
>
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.656;r2=1.657
>
> To me, it looks far too restrictive.  At least, I'd like to allow '-'
> and '_'.  Please see the attached patch.
>
> Any objections?

Shouldn't you fix whatever is trying to call compizmanager not to use 
.desktop file instead?

-- 
Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>