Date: Tue, 28 Feb 2006 14:51:49 -0500 From: John Baldwin <jhb@freebsd.org> To: Warner Losh <imp@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 92499 for review Message-ID: <200602281451.50834.jhb@freebsd.org> In-Reply-To: <200602280037.k1S0bQA5064273@repoman.freebsd.org> References: <200602280037.k1S0bQA5064273@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 27 February 2006 19:37, Warner Losh wrote: > http://perforce.freebsd.org/chv.cgi?CH=92499 > > Change 92499 by imp@imp_hammer on 2006/02/28 00:37:10 > > Make PIO interrupt fast... > > Affected files ... > > .. //depot/projects/arm/src/sys/arm/at91/at91_pio.c#5 edit > > Differences ... > > ==== //depot/projects/arm/src/sys/arm/at91/at91_pio.c#5 (text+ko) ==== > > @@ -124,7 +124,8 @@ > * Activate the interrupt, but disable all interrupts in the hardware > */ > WR4(sc, PIO_IDR, 0xffffffff); > - err = bus_setup_intr(dev, sc->irq_res, INTR_TYPE_MISC | INTR_MPSAFE, > + err = bus_setup_intr(dev, sc->irq_res, > + INTR_TYPE_MISC | INTR_MPSAFE | INTR_FAST, > at91_pio_intr, sc, &sc->intrhand); > if (err) { > AT91_PIO_LOCK_DESTROY(sc); You don't need the MPSAFE flag then. FAST handlers are required to be MPSAFE and don't ever run under Giant. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602281451.50834.jhb>