Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Jun 2005 17:01:14 -0700
From:      Marcel Moolenaar <marcel@xcllnt.net>
To:        Jeff Roberson <jeff@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys bio.h
Message-ID:  <cdae9246c661a61c3f81ecd36481ff27@xcllnt.net>
In-Reply-To: <200506122233.j5CMX60W020136@repoman.freebsd.org>
References:  <200506122233.j5CMX60W020136@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Jun 12, 2005, at 3:33 PM, Jeff Roberson wrote:

> jeff        2005-06-12 22:33:06 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/sys              bio.h
>   Log:
>    - switch_point is now unused.  This doesn't break module binary 
> compatability
>      since the structure is shrinking, not growing.

Not true. An array of bio_queue_head will be broken by this change.
Other breakages may be caused by having the field remain uninitialized
or clobbered from the perspective of a module. Passing by value is
also broken.

If ABI breakage is a concern, this change better be reverted.

-- 
  Marcel Moolenaar         USPA: A-39004          marcel@xcllnt.net




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cdae9246c661a61c3f81ecd36481ff27>