From owner-freebsd-gnome@FreeBSD.ORG  Sat Mar 15 16:21:17 2014
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B38CF2E3;
 Sat, 15 Mar 2014 16:21:17 +0000 (UTC)
Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214])
 by mx1.freebsd.org (Postfix) with ESMTP id 55E98A2C;
 Sat, 15 Mar 2014 16:21:16 +0000 (UTC)
Received: from gromit.timing.com (gromit.timing.com [206.168.13.209])
 by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id s2FFsXGF091627;
 Sat, 15 Mar 2014 09:54:33 -0600 (MDT)
 (envelope-from jhein@symmetricom.com)
Received: from gromit.timing.com (localhost [127.0.0.1])
 by gromit.timing.com (8.14.7/8.14.5) with ESMTP id s2FFsWX9098675;
 Sat, 15 Mar 2014 09:54:32 -0600 (MDT)
 (envelope-from jhein@gromit.timing.com)
Received: (from jhein@localhost)
 by gromit.timing.com (8.14.7/8.14.7/Submit) id s2FFsWZ2098674;
 Sat, 15 Mar 2014 09:54:32 -0600 (MDT) (envelope-from jhein)
Date: Sat, 15 Mar 2014 09:54:32 -0600 (MDT)
Message-Id: <201403151554.s2FFsWZ2098674@gromit.timing.com>
From: John Hein <john.hein@microsemi.com>
X-send-pr-version: 3.114
X-GNATS-Notify: 
Cc: gnome@freebsd.org, kwm@freebsd.org
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: John Hein <john.hein@microsemi.com>
List-Id: GNOME for FreeBSD -- porting and maintaining
 <freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-gnome>,
 <mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome/>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
 <mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Mar 2014 16:21:17 -0000


>Submitter-Id:	current-users
>Originator:	John Hein
>Organization:
>Confidential:	no 
>Synopsis:	[patch] fix staged pango
>Severity:	non-critical
>Priority:	low
>Category:	ports
>Class:		change-request
>Release:
>Environment:

>Description:

If pango did not exist before on a system, then <prefix>/etc/pango
would not be there.  When the pkg or port is installed, the @exec that
invokes pango-querymodules in the plist will silently fail because of
the missing directory.

>How-To-Repeat:

mv /usr/local/etc/pango /usr/local/etc/pango.mv
portmaster x11-toolkits/pango

Observe that packages that are dependent on pango for loading fonts
no longer load fonts, and you might see an error like so:

(pan:27235): Pango-CRITICAL **: No modules found:
No builtin or dynamically loaded modules were found.
PangoFc will not work correctly.
This probably means there was an error in the creation of:
  '/usr/local/etc/pango/pango.modules'
You should create this file by running:
  pango-querymodules > '/usr/local/etc/pango/pango.modules'



>Fix:

Remove the creation of the etc/pango dir from post-install.  Now
that this port supports staging, that doesn't help with the
installed port.  Instead create the directory in the plist.

While here, use PREFIX for the path to pango-querymodules in plist.
That seems more correct than LOCALBASE.

Index: Makefile
===================================================================
--- Makefile	(revision 348052)
+++ Makefile	(working copy)
@@ -56,7 +56,6 @@
 .endif
 
 post-install:
-	@${MKDIR} ${STAGEDIR}${PREFIX}/etc/pango/
 	@${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpango*-1.0.so.0
 	@${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/pango/*/modules/pango-*.so
 
Index: pkg-plist
===================================================================
--- pkg-plist	(revision 348052)
+++ pkg-plist	(working copy)
@@ -141,4 +141,5 @@
 @dirrm include/pango-1.0/pango
 @dirrm include/pango-1.0
 @dirrm etc/pango
-@exec %%LOCALBASE%%/bin/pango-querymodules > %D/etc/pango/pango.modules
+@exec mkdir %D/etc/pango
+@exec %%PREFIX%%/bin/pango-querymodules > %D/etc/pango/pango.modules