Date: Mon, 10 Jun 2019 09:02:55 -0600 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@bsdimp.com>, "Conrad E. Meyer" <cem@freebsd.org> Cc: Tijl Coosemans <tijl@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r348847 - head/sys/sys Message-ID: <f96e29b7fdbb0568a3f0b04878d514aa4ff436fe.camel@freebsd.org> In-Reply-To: <CANCZdfoJsHRL_0Jom6bsSC9J3EZn1d-WGA41hCsvWRTBhCVzhw@mail.gmail.com> References: <201906100528.x5A5S4gm072561@repo.freebsd.org> <20190610110909.3e6fbc13@kalimero.tijl.coosemans.org> <CAG6CVpViTYjjcqT6v_4m9RFk%2BGCr7kRNGeq63%2Bv4L_QgM3DEjQ@mail.gmail.com> <CANCZdfoJsHRL_0Jom6bsSC9J3EZn1d-WGA41hCsvWRTBhCVzhw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2019-06-10 at 07:49 -0600, Warner Losh wrote: > On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer <cem@freebsd.org> wrote: > > > On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans <tijl@freebsd.org> > > wrote: > > > On Mon, 10 Jun 2019 05:28:04 +0000 (UTC) Dmitry Chagin > > > <dchagin@FreeBSD.org> wrote: > > > > ... > > > > URL: https://svnweb.freebsd.org/changeset/base/348847 > > > > Log: > > > > Use C11 anonymous unions. > > > > > > > > Modified: head/sys/sys/ucred.h > > > > > > ... > > > > > > Isn't this a userland header that should work with non-C11 > > > compilers? > > > > Hi Tijl, > > > > Why would one expect userland headers to work with non-C11 (gnu89) > > compilers? > > > > Because those compilers can choose non c11 variants of the language? > > Warner > Do we promise that userland will compile with -std=c89? I hope not. Anonymous unions may be a c11 feature, but they're also available with -std=gnu99, which I think is how we compile userland. I think -std=gnu99 is how we should also compile the kernel, and I think Bruce has been trying to say that for several years (but I'm not sure, because the emails that seem to say so are always so full of semi-related extraneous material that it's hard to be sure what they're saying). -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f96e29b7fdbb0568a3f0b04878d514aa4ff436fe.camel>