From owner-freebsd-hackers@freebsd.org Fri Nov 20 20:58:51 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1ABF0A337F5 for ; Fri, 20 Nov 2015 20:58:51 +0000 (UTC) (envelope-from cemeyer@uw.edu) Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB7DD150A for ; Fri, 20 Nov 2015 20:58:50 +0000 (UTC) (envelope-from cemeyer@uw.edu) Received: by pacej9 with SMTP id ej9so126885816pac.2 for ; Fri, 20 Nov 2015 12:58:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uw-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=UwRLgshkyBPdEU0c80yn13CIBw4BqpoLR485nLhqukU=; b=dJ2b8XnkwCQQI+1oUHHdee2O8h6dvdtuhE87mhKlAjJlg+ionlxYqfsHFhJNkq8XNz 3KOgwmgPvMKqY9hAitVnqtmTATWjsSIqvPVxqCrT2TT1lai6ZWOUCArUjx3e5aI8m9l9 WZzbmxWyaW0dpcs9wk7XgGxe4TJ3oiVkO7gjgnQt3ZXQduBzQhX9QEkotxcEdtTrlLkg AxqhDjvuVStUvhBd26EFg4LfnLt2R642wgX2Hoo5C9AjbKJHrZZrwNE+wutkjzOZ3rXQ fNyddcaR/xHOFrp+lKbb3A0IH4sZcbUCMARDB+otk83wfCsiXau/cwtPZOI78uI9GT70 ywlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=UwRLgshkyBPdEU0c80yn13CIBw4BqpoLR485nLhqukU=; b=QxyUIWHLjUMGw4zNKETNM+/nyZ3ZSvXu8P+mWAjkYQt2sUn+290uFadEEFojlmhaL3 EbLbGCKI9ycv4T/ICjQ44FCch8qJdg/ImSZK1BZQMIptjscG5wEuLTBwWhnIy+w3dHkn SFWvb6mJHX4pgNQ77QaWufdzmG3jfAiaosQ2g4C8tYAAwbJM1goWawS+OwLO7puYrT8I PT3J6cokxkSVz0REBABwGpfRg5PdKycopjNU2bDEhJLR95WgndxlRmAvB3MIwzreezr7 u1HkPaWIduuGHj3dEAXo8pR8PWeTHj+CrKSxTYwM1dpii30FDHrjE+WbhkiMKF4EflAt UBAw== X-Gm-Message-State: ALoCoQmf7aBijGyn8OOSlGx83/Z8wv+galQupcBQ400UxQSADKheVRBkDMStL2blcFqcIAa+YTla X-Received: by 10.66.63.37 with SMTP id d5mr22024399pas.103.1448053130290; Fri, 20 Nov 2015 12:58:50 -0800 (PST) Received: from m (c-50-181-252-241.hsd1.wa.comcast.net. [50.181.252.241]) by smtp.gmail.com with ESMTPSA id sz9sm861485pab.13.2015.11.20.12.58.49 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Nov 2015 12:58:49 -0800 (PST) Date: Fri, 20 Nov 2015 12:58:46 -0800 From: Conrad Meyer To: freebsd-hackers@freebsd.org Subject: Re: libUCL / UCL as FreeBSD config question Message-ID: <20151120125846.31d4f4cc@m> In-Reply-To: <564F771F.4060408@freebsd.org> References: <5B598F72-C5DD-48FD-866D-F90E117D646E@rdsor.ro> <564F6118.5030702@freebsd.org> <1448048197.2765.74.camel@michaeleichorn.com> <564F771F.4060408@freebsd.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 20 Nov 2015 21:50:19 +0000 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2015 20:58:51 -0000 On Fri, 20 Nov 2015 14:40:15 -0500 Allan Jude wrote: > The issue is that UCL allows comments anywhere, for example: > > #above > FreeBSD: { > /* before */ url: > "pkg+http://pkg.FreeBSD.org/${ABI}/latest", mirror_type: /* > middle */ "srv", signature_type: "fingerprints", /* after */ > # under > fingerprints: "/root/keys/pkg", # inline-after > enabled: yes > } > > Etc. So the solution that was discussed was changing libucl > to use an Abstract Syntax Tree, but that is a lot of work. > So for now, I am not sure what the best approach is. I think an AST that keeps comments is a good approach going forwards. We don't need a short-term fix that is anything less than that. Best, Conrad