From owner-cvs-src@FreeBSD.ORG Sat Dec 29 06:33:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B45616A417; Sat, 29 Dec 2007 06:33:24 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mx.egr.msu.edu (surfnturf.egr.msu.edu [35.9.37.164]) by mx1.freebsd.org (Postfix) with ESMTP id BF47E13C457; Sat, 29 Dec 2007 06:33:24 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from localhost (localhost.egr.msu.edu [127.0.0.1]) by mx.egr.msu.edu (Postfix) with ESMTP id 412072EB8F0; Sat, 29 Dec 2007 01:17:31 -0500 (EST) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mx.egr.msu.edu ([127.0.0.1]) by localhost (surfnturf.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WPyWDHPExr8c; Sat, 29 Dec 2007 01:17:31 -0500 (EST) Received: from localhost (daemon.egr.msu.edu [35.9.44.65]) by mx.egr.msu.edu (Postfix) with ESMTP id 17C412EB8AC; Sat, 29 Dec 2007 01:17:31 -0500 (EST) Received: by localhost (Postfix, from userid 21281) id 1442A33C22; Sat, 29 Dec 2007 01:17:31 -0500 (EST) Date: Sat, 29 Dec 2007 01:17:31 -0500 From: Adam McDougall To: Robert Watson Message-ID: <20071229061730.GY68594@egr.msu.edu> References: <200711271220.lARCKxFm040533@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200711271220.lARCKxFm040533@repoman.freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Dec 2007 06:33:25 -0000 Can this be merged to 6 as well? I've been running the patch ported to 6-stable for a while with no problems. Thanks. On Tue, Nov 27, 2007 at 12:20:59PM +0000, Robert Watson wrote: rwatson 2007-11-27 12:20:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/nfsclient nfs_vnops.c Log: Merge nfs_vnops.c:1.277 from HEAD to RELENG_7: Remove hacks from the NFSv2/3 client intended to handle a lack of a server-side RPC retranmission cache for non-idempotent operations: these hacks substituted 0 (success) for the expected EEXIST in the event that a target name already existed for LINK, SYMLINK, and MKDIR operations, under the assumption that EEXIST represented a second application of the original RPC rather than a true failure. Background: certain NFS operations (in this case, LINK, SYMLINK, and MKDIR) are not idempotent, as they leave behind persisting state on the server that prevents them from being replayed without an error;if an UDP RPC reply is lost leading to a retransmission by theclient, the second reply will return EEXIST rather than success, asthe new object has already been created. The NFS client previouslysilently mapped the EEXIST return into success to paper over thisproblem. However, in all modern NFS server implementations, a reply cache is kept in order to retransmit the original reply to a retransmitted request, rather than performing the operation a second time, allowing this hack to be avoided. This allows link()-based filelocking over NFS to operate correctly, as an application requestingthe creation of a new link for a file to tell if it succeededatomically or not. Other NFS clients, including Solaris and Linux, generally follow this behavior for the same reasons. Most clients also now default to TCP, which also helps avoid the issue of retransmitted but non-idempotent requests in most cases. Reported by: Adam McDougall , Timo Sirainen Reviewed by: mohans Approved by: re (kensmith) Revision Changes Path 1.276.2.1 +4 -25 src/sys/nfsclient/nfs_vnops.c _______________________________________________ cvs-src@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-src To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org"