From owner-freebsd-arch@FreeBSD.ORG Wed Jun 30 10:02:56 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD14816A4CE; Wed, 30 Jun 2004 10:02:56 +0000 (GMT) Received: from blount.mail.mindspring.net (blount.mail.mindspring.net [207.69.200.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B3D243D58; Wed, 30 Jun 2004 10:02:56 +0000 (GMT) (envelope-from tlambert2@mindspring.com) Received: from [192.168.167.46] (helo=wamui08.slb.atl.earthlink.net) by blount.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BfbvT-0006Ry-00; Wed, 30 Jun 2004 06:02:47 -0400 Message-ID: <9697234.1088589767326.JavaMail.root@wamui08.slb.atl.earthlink.net> Date: Wed, 30 Jun 2004 03:02:46 -0700 (GMT-07:00) From: Terry Lambert To: Tim Robbins , Poul-Henning Kamp Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailer: Earthlink Zoo Mail 1.0 cc: arch@freebsd.org cc: David Schultz cc: marcel@xcllnt.net cc: freebsd-arch@freebsd.org Subject: Re: COMPAT_43 tty processing ? X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Terry Lambert List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2004 10:02:56 -0000 Tim Robbins wrote: > On Fri, Jun 25, 2004 at 12:22:01PM +0200, Poul-Henning Kamp wrote: > > In message <200406241859.54810.peter@wemm.org>, Peter Wemm writes: > > >On Wednesday 23 June 2004 04:27 pm, David Schultz wrote: > > >> On Mon, Jun 21, 2004, Poul-Henning Kamp wrote: > > >> > Do we need the COMPAT_43 tty processing in 5-STABLE ? > > >> > > >> FWIW, I used to run with COMPAT_43 disabled entirely. I think the > > >> only breakage I noticed was that the Linuxolator didn't work > > >> anymore because of a number of `#ifdef COMPAT_43's in the socket > > >> code that linux.ko depends on. > > > > > >These should probably be broken out as COMPAT_OLDSOCK, whih is implied > > >by the linuxulator or COMPAT_43 or the like. > > > > Or better yet: made unncessary in the linuxolator ? > > This is what NetBSD has done. At one stage I had patches derived from > their code that removed the need for the COMPAT_43 socket functions, > but COMPAT_43 was still necessary for ostat(), etc. Please do not remove any code protected by COMPAT_43 which provides any of the functionality listed on either of the following two standards document references: http://www.opengroup.org/onlinepubs/009695399/basedefs/termios.h.html http://www.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap11.html#tag_11 (Yes, I know that this code should not be inside COMPAT_43 protection, but as far as I can tell, no on has disentagled it). -- Terr