From owner-p4-projects@FreeBSD.ORG  Tue Apr 26 23:15:49 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0E71C16A4D0; Tue, 26 Apr 2005 23:15:49 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C1E1F16A4CE
	for <perforce@freebsd.org>; Tue, 26 Apr 2005 23:15:48 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8F0E343D55
	for <perforce@freebsd.org>; Tue, 26 Apr 2005 23:15:48 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j3QNFmUo059081
	for <perforce@freebsd.org>; Tue, 26 Apr 2005 23:15:48 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j3QNFmKB059078
	for perforce@freebsd.org; Tue, 26 Apr 2005 23:15:48 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Tue, 26 Apr 2005 23:15:48 GMT
Message-Id: <200504262315.j3QNFmKB059078@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 76038 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2005 23:15:50 -0000

http://perforce.freebsd.org/chv.cgi?CH=76038

Change 76038 by rwatson@rwatson_paprika on 2005/04/26 23:14:47

	Return errno values in various error cases associated with
	audit record construction.

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#9 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#9 (text+ko) ====

@@ -111,6 +111,7 @@
 		rec->data = (u_char *) malloc (MAX_AUDIT_RECORD_SIZE * sizeof(u_char));
 		if(rec->data == NULL) {
 			free(rec);
+			errno = ENOMEM;
 			return -1;
 		}
 
@@ -122,6 +123,7 @@
 			free(rec);
 
 			/* XXX We need to increase size of MAX_AUDIT_RECORDS */
+			errno = ENOMEM;
 			return -1;
 		}
 		rec->desc = bsm_rec_count;
@@ -264,6 +266,7 @@
 		
 	rec = open_desc_table[d];
 	if((rec == NULL) || (rec->used == 0)) {
+		errno = EINVAL;
 		return -1; /* Invalid descriptor */
 	}