From owner-freebsd-net Fri Jun 28 1:20:38 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D5EB37B405 for ; Fri, 28 Jun 2002 01:20:14 -0700 (PDT) Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA54B43E06 for ; Fri, 28 Jun 2002 01:20:13 -0700 (PDT) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020628082013.HRMS9178.rwcrmhc51.attbi.com@InterJet.elischer.org>; Fri, 28 Jun 2002 08:20:13 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id BAA73157; Fri, 28 Jun 2002 01:15:14 -0700 (PDT) Date: Fri, 28 Jun 2002 01:15:13 -0700 (PDT) From: Julian Elischer To: Luigi Rizzo Cc: net@FreeBSD.ORG Subject: Re: luigi, kernel module build broken by ipfw In-Reply-To: <20020628004710.A55603@iguana.icir.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org also: cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wno-format -ansi -g -nostdinc -I- -I. -I../../.. -I../../../dev -I../../../contrib/dev/acpica -I../../../contrib/ipfilter -I../../../../include -D_KERNEL -include opt_global.h -fno-common -mpreferred-stack-boundary=2 -ffreestanding -Werror ../../../netinet/ip_fw2.c cc1: warnings being treated as errors ../../../netinet/ip_fw2.c: In function `ipfw_chk': ../../../netinet/ip_fw2.c:1781: warning: deprecated use of label at end of compound statement *** Error code 1 my quick answer is add a ";" on line 1780 but there is probably a beter way On Fri, 28 Jun 2002, Luigi Rizzo wrote: > On Fri, Jun 28, 2002 at 12:23:14AM -0700, Julian Elischer wrote: > oh, i forgot that... > i cannot test it right now but the fix should be trivial > in src/sys/modules/ipfw/Makefile, replace ip_fw.c with ip_fw2.c > > (and if it works, could you commit it ?) > > cheers > luigi > > > > with freshly checked out sources, I can not build the modules... > > > > ===> ipfw > > cc -g -O -pipe -DIPFIREWALL -D_KERNEL -Wall -Wredundant-decls > > -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith > > -Winline -Wcast-qual -Wno-format -ansi -DKLD_MODULE -nostdinc -I- > > -I. -I@ -I@/dev -I@/../include -fno-common -g -mpreferred-stack-boundary=2 > > -ffreestanding -Wall -Wredundant-decls -Wnested-externs > > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > > -Wcast-qual -Wno-format -ansi -c /usr/src/sys/netinet/ip_fw.c > > /usr/src/sys/netinet/ip_fw.c:216: warning: `union ip_fw_if' declared > > inside parameter list > > /usr/src/sys/netinet/ip_fw.c:216: warning: its scope is only this > > definition or declaration, which is probably not what you want > > /usr/src/sys/netinet/ip_fw.c: In function `tcpflg_match': > > /usr/src/sys/netinet/ip_fw.c:273: structure has no member named `fw_ipflg' > > /usr/src/sys/netinet/ip_fw.c:273: `IP_FW_IF_TCPEST' undeclared (first use > > in this function) > > /usr/src/sys/netinet/ip_fw.c:273: (Each undeclared identifier is reported > > only once > > /usr/src/sys/netinet/ip_fw.c:273: for each function it appears in.) > > > > [...] > > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-net" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message