Date: Sat, 19 Nov 2005 21:47:58 +0100 From: "Damien Bergamini" <damien.bergamini@free.fr> To: "Nate Lawson" <nate@root.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/iwi Makefile src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h Message-ID: <00ca01c5ed4a$86b0e570$0300a8c0@COMETE> References: <20051119165547.0A4BD16A43D@hub.freebsd.org> <437F82A1.6080504@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
| I'm a little concerned about this change. The notes claim the firmware | is loaded after a resume from the filesystem as well as at | initialization time. So your driver is then assuming the ATA driver is | fully reinitialized before your driver's resume method can be called. | You can't assume that since it's not a child device of ATA. Wouldn't the call to VOP_READ block until "/" is recovered in that case ? Or is it possible to delay the call to if_init until "/" is ready ? I know OpenBSD and NetBSD have mountroot hooks but I'm anaware of such a thing in FreeBSD. I've never been able to resume from any suspend mode on my laptop so I can't test this right now. | Also, I'm concerned about the unnecessary use of caddr_t (which I don't | think will work on PAE or 64 bit systems). | | -- | Nate I'll convert them to void* then, though I don't see why it hurts. Damien
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?00ca01c5ed4a$86b0e570$0300a8c0>