From owner-svn-ports-all@freebsd.org  Wed Nov  7 10:15:14 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 381331122C17;
 Wed,  7 Nov 2018 10:15:14 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AF6948B477;
 Wed,  7 Nov 2018 10:15:13 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 8FC0CD5B4; Wed,  7 Nov 2018 10:15:13 +0000 (UTC)
Date: Wed, 7 Nov 2018 10:15:13 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Koichiro Iwao <meta@freebsd.org>
Cc: Niclas Zeising <zeising@freebsd.org>,
 Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r484357 - head/mail/spamassassin
Message-ID: <20181107101513.GA81078@FreeBSD.org>
References: <201811062146.wA6LknN3005274@repo.freebsd.org>
 <20181107083105.55o52urafcgdthec@ivaldir.net>
 <20181107091004.xbvzfyviyrkcbi2m@icepick.vmeta.jp>
 <ca100d9e-c455-27c3-5605-2ecbb3c5a4bb@freebsd.org>
 <20181107092211.dgcvichyunbss35x@ivaldir.net>
 <2b3670de-7625-d458-7c93-5ea0a7ae2af1@freebsd.org>
 <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: AF6948B477
X-Spamd-Result: default: False [-106.68 / 200.00]; ARC_NA(0.00)[];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org];
 FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[];
 TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0];
 MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org];
 R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6];
 IP_SCORE(-3.57)[ip: (-9.35), ipnet: 96.47.64.0/20(-4.67), asn: 11403(-3.74),
 country: US(-0.09)]; MX_GOOD(-0.01)[cached: mx66.freebsd.org];
 NEURAL_HAM_SHORT(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[];
 R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US];
 MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Nov 2018 10:15:14 -0000

On Wed, Nov 07, 2018 at 06:55:28PM +0900, Koichiro Iwao wrote:
> ...
> +1 to single port. I concern about not all people need that patch. Can
> FLAVORS be used to create packages with/without Japanese patches?
> I know it can be used to handle multiple versions of PHP, Python, etc.

There's nothing wrong with a patch not being *useful* to all people,
the question is would it break anything for anyone.  If there are no
undesired side effects just commit it without hiding it behind options
or flavors.

./danfe